fix: add compatibility with prettier v3.6.0#246
Merged
danielpza merged 2 commits intofardad-dev:masterfrom Jun 27, 2025
Merged
Conversation
Collaborator
|
@azat-io can you add a test or update the prettier version in the package.json to the latest to check that it works on the latest prettier version? |
Contributor
Author
|
Done! |
Contributor
|
Thanks for the fix. Just curious, what's your release process? I.e., when can we expect this change to land on NPM? |
Owner
|
Released v1.3.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245.
Plugin crashes with
TypeError: Cannot read properties of undefined (reading 'length')when using Prettier 3.6.0 due to changes in the AST structure whereast.tokenscan beundefined.Added defensive checks in two places:
parser.ts: Check ifast.tokensexists before callingfindTokenIndexutils.ts: Add null/undefined guards infindTokenIndexfunctiongetParamsOrders: Handle case whentokenIndexis -1