[flags] add enableEffectEventMutationPhase #35548
Open
+448
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: be3fb29...5804ed3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
commented
Jan 17, 2026
| ...(gate('enableViewTransition') && | ||
| !gate('enableEffectEventMutationPhase') | ||
| ? ['Child Layout Create A 3 2 B 1 1 1'] | ||
| : ['Child Layout Create A 3 2 B 3 2 2']), |
Member
Author
There was a problem hiding this comment.
@sebmarkbage can you review these tests and let me know if you think the first or second logs are right? Inside enableViewTransition, when a tree goes from hidden to visible we were not updating the useEffectEvent callback ref.
rickhanlonii
commented
Jan 18, 2026
| }); | ||
|
|
||
| // @gate enableActivity | ||
| it('effect events are fresh in deeply nested hidden Activities', async () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization for useEffectEvent. Not sure we even need a flag for it, but it will be a nice killswitch.
As an added benefit, it fixes a bug when
enableViewTransitionis on, where we were not updating the useEffectEvent callback when a tree went from hidden to visible.