[Flight] Forward early debug info for lazy chunks #35506
Draft
+862
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubieowoce
changed the title
lubieowoce
force-pushed
the
reencode-debug-info
branch
8 times, most recently
from
b6057e3 to
bb3681d
Compare
lubieowoce
changed the title
unstubbable
changed the title
lubieowoce
force-pushed
the
reencode-debug-info
branch
2 times, most recently
from
3cc2596 to
8a3fc67
Compare
lubieowoce
force-pushed
the
reencode-debug-info
branch
from
8a3fc67 to
650670c
Compare
Contributor
Author
|
converting back to a draft because the deduping solution implemented here doesn't work well, so we end up repeating the early debugInfo on the resolved value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we're re-encoding a lazy chunk that came from a flight stream, we wait for the chunk to resolve, and then forward the debug info. This unnecessarily delays debug info that's already available while the chunk is still pending, like the name and stack info. This PR attempts to make it so that we emit whatever debug info we have before initializing the lazy chunk (which may suspend), and then emit the rest after.
When a debug info array is partially emitted, we save the number of emitted entries we already emitted in a WeakMap
request.partialDebugInfoProgress. That way, when we emit it again later, we know how many entries to skip.Most debug infos are not partially emitted -- we currently only do this for lazy elements -- so to avoid the overhead of tracking the index for each debug info array, we only do this if it's emitted using
forwardDebugInfoProgressive.Notably, we also need to handle cases when debug entries are transferred from the lazy chunk onto the inner element (i.e. moved to a different array) via
moveDebugInfoFromChunkToInnerValue:react/packages/react-client/src/ReactFlightClient.js
Lines 1275 to 1291 in b546603
In this case, we have to make sure that new array has the same progress as the source. We do this in
copyDebugInfoProgressToResolvedValue.