Add tests for multi-session Tracing domain support (first to trace wins) #55287
+179
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: TSIA Reviewed By: hoxyq Differential Revision: D90998980
…ebook#55240) Summary: Changelog: [General][Fixed] Send network events to all CDP clients with the Network domain enabled Reviewed By: hoxyq Differential Revision: D90888854
…ns) (facebook#55287) Summary: Changelog: [Internal] Adds tests (and a doc comment) codifying the existing, correct behavior of the CDP `Tracing.start` command when there is already a tracing session in progress. Reviewed By: hoxyq Differential Revision: D90888857
motiz88
force-pushed
the
export-D90888857
branch
from
4184926 to
dbf5b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Adds tests (and a doc comment) codifying the existing, correct behavior of the CDP
Tracing.startcommand when there is already a tracing session in progress.Reviewed By: hoxyq
Differential Revision: D90888857