Support getBoundingClientRect for TextShadowNode#55278
Open
andrewdacenko wants to merge 1 commit intofacebook:mainfrom
Open
Support getBoundingClientRect for TextShadowNode#55278andrewdacenko wants to merge 1 commit intofacebook:mainfrom
andrewdacenko wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@andrewdacenko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91087220. |
andrewdacenko
force-pushed
the
export-D91087220
branch
from
334bf7c to
331d996
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
331d996 to
adc9193
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
adc9193 to
276ddaf
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
2 times, most recently
from
0a57641 to
2ab74cc
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
2ab74cc to
78c5db1
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
78c5db1 to
900813f
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
900813f to
7bf3af0
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
7bf3af0 to
aa30bd2
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
aa30bd2 to
28063bb
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
28063bb to
216fbb1
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
216fbb1 to
fffa65e
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
from
fffa65e to
807de34
Compare
andrewdacenko
force-pushed
the
export-D91087220
branch
2 times, most recently
from
a33be80 to
1b6caf1
Compare
Summary: Changelog: [General][Added] - Add DOM getBoundingClientRect() for nested text When `getBoundingClientRect()` is called on a nested `<Text>` component (TextShadowNode), return the parent paragraph's bounding rect instead of empty/invalid metrics. TextShadowNode is a virtual node that doesn't have its own layout metrics. This matches web behavior where inline elements return their container's rect. Use `getClientRects()` (added in a follow-up diff) to get the individual fragment rects for text that spans multiple lines. Differential Revision: D91087220
andrewdacenko
force-pushed
the
export-D91087220
branch
from
1b6caf1 to
2d17859
Compare
andrewdacenko
added a commit
to andrewdacenko/react-native
that referenced
this pull request
Jan 28, 2026
Summary: Changelog: [General][Added] - Add DOM getBoundingClientRect() for nested text When `getBoundingClientRect()` is called on a nested `<Text>` component (TextShadowNode), return the parent paragraph's bounding rect instead of empty/invalid metrics. TextShadowNode is a virtual node that doesn't have its own layout metrics. This matches web behavior where inline elements return their container's rect. Use `getClientRects()` (added in a follow-up diff) to get the individual fragment rects for text that spans multiple lines. Differential Revision: D91087220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When
getBoundingClientRect()is called on a nested<Text>component(TextShadowNode), return the parent paragraph's bounding rect instead of
empty/invalid metrics.
TextShadowNode is a virtual node that doesn't have its own layout metrics.
This matches web behavior where inline elements return their container's
rect. Use
getClientRects()(added in a follow-up diff) to get theindividual fragment rects for text that spans multiple lines.
Differential Revision: D91087220