Remove ComponentStack → Stack conversion#55228
Closed
rickhanlonii wants to merge 3 commits intofacebook:mainfrom
Closed
Remove ComponentStack → Stack conversion#55228rickhanlonii wants to merge 3 commits intofacebook:mainfrom
rickhanlonii wants to merge 3 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@rickhanlonii has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90896380. |
rickhanlonii
added a commit
to rickhanlonii/react-native
that referenced
this pull request
Jan 28, 2026
Summary: LogBox was doing a wasteful round-trip conversion: parseComponentStack converted Stack → ComponentStack, stored it that way, then convertComponentStackToStack converted it back every time it was used. This eliminates the unnecessary conversion by storing componentStack as Stack directly from the start. The ComponentStack type is removed entirely since it's no longer needed. Also consolidates duplicate helper functions in LogBoxLog-test.js by removing createStackForComponentStack and createComponentStack, keeping only the createStack helper. Reviewed By: vzaidman Differential Revision: D90896380
rickhanlonii
added a commit
to rickhanlonii/react-native
that referenced
this pull request
Jan 28, 2026
Summary: LogBox was doing a wasteful round-trip conversion: parseComponentStack converted Stack → ComponentStack, stored it that way, then convertComponentStackToStack converted it back every time it was used. This eliminates the unnecessary conversion by storing componentStack as Stack directly from the start. The ComponentStack type is removed entirely since it's no longer needed. Also consolidates duplicate helper functions in LogBoxLog-test.js by removing createStackForComponentStack and createComponentStack, keeping only the createStack helper. Reviewed By: vzaidman Differential Revision: D90896380
Summary: Remove tests that only test legacy component stack behavior. The 'stack' tests provide equivalent coverage for all scenarios. Legacy component stacks used a custom React string format (`\n in ComponentName (at filename.js:123)`) that was not symbolicated. The modern 'stack' format uses native JS Error stack frames that get properly symbolicated. This is the first step in removing `componentStackType` from LogBox entirely. The legacy parsing logic will be removed in a follow-up diff. Reviewed By: vzaidman Differential Revision: D90888272
Summary: All component stacks now use the native JS Error stack frame format which gets properly symbolicated. This removes the legacy/stack distinction since the legacy format (custom React string format) is no longer used. After this change, all component stacks will be symbolicated, improving the debugging experience. Reviewed By: vzaidman, javache Differential Revision: D90888223
Summary: LogBox was doing a wasteful round-trip conversion: parseComponentStack converted Stack → ComponentStack, stored it that way, then convertComponentStackToStack converted it back every time it was used. This eliminates the unnecessary conversion by storing componentStack as Stack directly from the start. The ComponentStack type is removed entirely since it's no longer needed. Also consolidates duplicate helper functions in LogBoxLog-test.js by removing createStackForComponentStack and createComponentStack, keeping only the createStack helper. Reviewed By: vzaidman Differential Revision: D90896380
rickhanlonii
force-pushed
the
export-D90896380
branch
from
dabf98d to
902246c
Compare
|
This pull request has been merged in f56f942. |
Collaborator
|
This pull request was successfully merged by @rickhanlonii in f56f942 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
LogBox was doing a wasteful round-trip conversion: parseComponentStack converted Stack → ComponentStack, stored it that way, then convertComponentStackToStack converted it back every time it was used.
This eliminates the unnecessary conversion by storing componentStack as Stack directly from the start. The ComponentStack type is removed entirely since it's no longer needed.
Also consolidates duplicate helper functions in LogBoxLog-test.js by removing createStackForComponentStack and createComponentStack, keeping only the createStack helper.
Reviewed By: vzaidman
Differential Revision: D90896380