Skip to content

Formalise ENABLE_TIMELINE_FRAMES experiment#242

Merged
huntie merged 1 commit intofacebook:mainfrom
huntie:experiment-frames-track
Mar 5, 2026
Merged

Formalise ENABLE_TIMELINE_FRAMES experiment#242
huntie merged 1 commit intofacebook:mainfrom
huntie:experiment-frames-track

Conversation

@huntie
Copy link
Member

@huntie huntie commented Mar 5, 2026

Summary

Note

Paired with facebook/react-native#55941, should be synced into react-native afterwards.

Formalise the existing ENABLE_TIMELINE_FRAMES experiment, by removing the scattered globalThis.enableTimelineFrames and platform === 'android' checks, and ensuring the UI is correctly synced in both states.

This allows us to control enabling this feature from the backend (ReactNativeApplication.metadataEnabled → { unstable_frameRecordingEnabled }), as we experiment and add support per platform.

Also cleans up additional code forks in TimelinePanel.js.

Rollout plan (future)

  • Development unstable_frameRecordingEnabled (this change): Backend-driven enabling of this experiment, when the corresponding React Native feature flag is enabled.
  • Canary: At some point in the future when the CDP backend is semi-stable on both platforms, enable by default in RN, but preserve the ENABLE_TIMELINE_FRAMES experiment here — enabling per-user opt-in.
  • Stable: Remove flag from frontend for general rollout.

Test plan

Experiment disabled

image

✅ No Screenshots toggle available

Experiment enabled

When unstable_frameRecordingEnabled is sent by the backend:

image

✅ Initial user notification for backend-touched experiment

image

✅ Upon refresh, Screenshots toggle is enabled in Performance panel

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

@meta-cla meta-cla bot added the cla signed label Mar 5, 2026
@huntie huntie force-pushed the experiment-frames-track branch from 8310604 to ce986ec Compare March 5, 2026 16:43
@huntie huntie force-pushed the experiment-frames-track branch from ce986ec to fb16e5d Compare March 5, 2026 17:41
@huntie huntie marked this pull request as ready for review March 5, 2026 17:44
@huntie huntie merged commit 571dc30 into facebook:main Mar 5, 2026
5 checks passed
@huntie huntie deleted the experiment-frames-track branch March 5, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants