[Nexthop][m4062nhp] Add 4x200G-FR4 speed combination so qsfp_service can program FR4_2x400G optics - #1526
Closed
zackary-nexthop wants to merge 1 commit into
Conversation
Contributor
|
@srikrishnagopu has imported this pull request. If you are a Meta employee, you can view this in D117410585. |
…am FR4_2x400G optics Signed-off-by: Zackary Ayoun <zackary@nexthop.ai>
zackary-nexthop
force-pushed
the
zackary-nexthop.m4062nhp.fr4-2x400g-4x200g-combo
branch
from
August 28, 2026 10:22
c75fd40 to
56c2293
Compare
|
@zackary-nexthop has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@srikrishnagopu merged this pull request in 85d2fc4. |
zackary-nexthop
deleted the
zackary-nexthop.m4062nhp.fr4-2x400g-4x200g-combo
branch
September 8, 2026 10:55
snisha-cisco
pushed a commit
to snisha-cisco/fboss
that referenced
this pull request
Sep 11, 2026
…0G optics (facebook#1526) Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` Under 4x200G breakout (`PROFILE_200G_2_PAM4_RS544X2N_OPTICAL`, 200G on 2 host lanes), `qsfp_service` cannot program `FR4_2x400G` optics: the properties entry for media interface 11 declares 200G only on 4 host lanes, so application selection finds no candidate and every module fails with `Unsupported Application`, retrying forever at about 6/s. The modules do advertise a matching application (`200GAUI-2-L`, media code `0xC0`, 2 host lanes, host-assign `0x55`). This adds the missing combination to entry `"11"` of `TransceiverPropertiesDefault.h`: four 200G ports on host/media lanes 0/2/4/6 with `mediaLaneCode` `0xC0`, plus the `2x400G-FR4` to `4x200G-FR4` speed-change transition. The byte gets a proper name, `SMFMediaInterfaceCode::FR2_200G = 0xC0`, alongside a new `MediaInterfaceCode::FR2_200G = 37` used as the combo's reporting code, and `verify200gProfile` in the hw_test utils accepts both. No logic touched, data and enum values only. Pull Request resolved: facebook#1526 Test Plan: Validated the exact JSON on an m4062nhp (INNOLIGHT T-OL8CNT-NFM optics) by loading it through the `--transceiver_properties_config` runtime override: - Reproduced first: flipped cage 1 to 4x200G on stock defaults, got the ticket's `Unsupported Application` retry loop. - With the new table: config loads (`Loaded transceiver properties config with 14 SMF entries`), modules program to app 5, all lanes `ACTIVATED`, `Current Media Interface: 192` (`0xC0`), zero errors. - Regression: reverted the cage to 800G with the new table still loaded; module reprogrammed to app 6 (`FR8_800G`) cleanly. Box restored to its original config, all 128 links up. Reviewed By: xanabani Differential Revision: D117410585 Pulled By: srikrishnagopu fbshipit-source-id: 91912dd724b396e1a1cc5f9533a7be5de13a5e4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Under 4x200G breakout (
PROFILE_200G_2_PAM4_RS544X2N_OPTICAL, 200G on 2 host lanes),qsfp_servicecannot programFR4_2x400Goptics: the properties entry for media interface 11 declares 200G only on 4 host lanes, so application selection finds no candidate and every module fails withUnsupported Application, retrying forever at about 6/s. The modules do advertise a matching application (200GAUI-2-L, media code0xC0, 2 host lanes, host-assign0x55).This adds the missing combination to entry
"11"ofTransceiverPropertiesDefault.h: four 200G ports on host/media lanes 0/2/4/6 withmediaLaneCode0xC0, plus the2x400G-FR4to4x200G-FR4speed-change transition. The byte gets a proper name,SMFMediaInterfaceCode::FR2_200G = 0xC0, alongside a newMediaInterfaceCode::FR2_200G = 37used as the combo's reporting code, andverify200gProfilein the hw_test utils accepts both. No logic touched, data and enum values only.Test Plan
Validated the exact JSON on an m4062nhp (INNOLIGHT T-OL8CNT-NFM optics) by loading it through the
--transceiver_properties_configruntime override:Unsupported Applicationretry loop.Loaded transceiver properties config with 14 SMF entries), modules program to app 5, all lanesACTIVATED,Current Media Interface: 192(0xC0), zero errors.FR8_800G) cleanly. Box restored to its original config, all 128 links up.