Conversation
asrouji
force-pushed
the
asrouji/show-sample-packet-hw-object
branch
from
August 13, 2026 19:04
27c2192 to
b4a4f56
Compare
asrouji
marked this pull request as ready for review
August 13, 2026 19:18
Contributor
|
Please update the test plan with the test result of the sample object dump. |
srikrishnagopu
self-requested a review
August 13, 2026 20:59
Contributor
Author
|
Thanks @srikrishnagopu, I added the command and output from the test to the PR description. |
Contributor
|
Can you please rebase ? This has conflicts. |
Add SAMPLE_PACKET to HwObjectType and map it to the corresponding SAI object type in SaiSwitch::listObjects(). This lets cached and uncached show hw-object queries display programmed sample rates. Include it in the CLI help and cover the fboss2 argument parsing path.
asrouji
force-pushed
the
asrouji/show-sample-packet-hw-object
branch
from
August 16, 2026 18:34
b4a4f56 to
08e3605
Compare
|
@asrouji has updated the pull request. You must reimport the pull request before landing. |
Contributor
Author
|
@srikrishnagopu rebase done. I also added |
Contributor
|
@srikrishnagopu has imported this pull request. If you are a Meta employee, you can view this in D116223234. |
Contributor
|
@srikrishnagopu merged this pull request in b8feccc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
fboss2 show hw-object SAMPLE_PACKETfails during argument parsing becauseSAMPLE_PACKETis missing fromHwObjectType, even though FBOSS already creates and programs SAI sample-packet objects.Add
SAMPLE_PACKETtoHwObjectTypeand map it toSAI_OBJECT_TYPE_SAMPLEPACKETinSaiSwitch::listObjects(). This enables both cached and uncached queries to display the sample-packet attributes, including the programmed sample rate. Also include the new type in the CLI help and argument parser coverage.Test Plan
pre-commit run --from-ref upstream/main --to-ref HEAD; all applicable checks passed.fboss2and SAI hardware agent binaries on a live Cisco C8501 (MORGAN800CC) and configured an ingress sFlow sample rate of 90,000. Both cached and uncached queries returned the programmed sample rate: