Skip to content

feat(selector): add ghost variant - #4684

Merged
cixzhang merged 1 commit into
mainfrom
feat/selector-ghost-variant
Aug 4, 2026
Merged

feat(selector): add ghost variant#4684
cixzhang merged 1 commit into
mainfrom
feat/selector-ghost-variant

Conversation

@cixzhang

@cixzhang cixzhang commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaces #3980 which proposes to add selection to dropdown menus. The goal was to have a selector with ghost appearance, so adding the ghost variant here instead.

Adds variant="ghost" to Selector and MultiSelector so picker-style controls can sit visually alongside ghost buttons in toolbar rows. The existing bordered form-control treatment is now named variant="input" and remains the default.

What changed

  • Adds a borderless, button-like ghost trigger treatment with matching hover, pressed, focus, disabled, and auto-width behavior.
  • Reflects variant="input" | "ghost" on the theme target surface for both selector components.
  • Treats attached status as invalid for ghost triggers by detaching it by default; compact toolbar examples use statusVariant="tooltip" when status feedback needs to stay inline.
  • Adds Storybook coverage, doc metadata/guidance, CLI/docsite example blocks, and a changeset.

Testing

  • vitest run packages/core/src/Selector/Selector.test.tsx packages/core/src/MultiSelector/MultiSelector.test.tsx
  • pnpm -F @astryxdesign/core typecheck
  • eslint on changed implementation, test, story, and example files
  • node scripts/check-sync.js
  • node scripts/check-changesets.mjs
  • git diff --check
  • node apps/docsite/scripts/generate-data.mjs (succeeded; fresh-worktree warnings only for unbuilt theme package outputs)

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 4, 2026 8:10pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 3, 2026
@github-actions github-actions Bot added the needs:design-review Affects visuals — Design should review label Aug 3, 2026
@cixzhang
cixzhang force-pushed the feat/selector-ghost-variant branch from 71e7c9d to a3868d7 Compare August 3, 2026 20:32
@cixzhang
cixzhang enabled auto-merge (squash) August 3, 2026 21:01
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

MultiSelector (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 1448 -
Complexity N/A Very High (177) -
Selector (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 1431 -
Complexity N/A Very High (138) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.9KB 1.3KB

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

github-actions Bot added a commit that referenced this pull request Aug 4, 2026
@cixzhang
cixzhang force-pushed the feat/selector-ghost-variant branch from a3868d7 to 0b86a1f Compare August 4, 2026 20:04
github-actions Bot added a commit that referenced this pull request Aug 4, 2026
@cixzhang
cixzhang merged commit ebed74f into main Aug 4, 2026
19 checks passed
github-actions Bot added a commit that referenced this pull request Aug 4, 2026
@github-actions
github-actions Bot deleted the feat/selector-ghost-variant branch August 5, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. needs:design-review Affects visuals — Design should review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant