fix(bindings): reject same-instance callback re-entry#1331
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
external_handlerre-entry in the Python bindings before it can block on the interpreter mutexonOutputre-entry in the JS bindings, including pre-obtainedfs()handles and syncexecuteSync()callbacksRoot Cause
Both bindings delivered user callbacks while the same
Bashinstance was still mid-execution and still owned the interpreter/runtime access needed by live methods. If the callback re-entered the same instance throughexecute*,read_file/readFile, orfs(), the binding tried to reacquire that state and either hung or panicked instead of failing cleanly.Validation
just pre-prnode --test crates/bashkit-js/__test__/runtime-compat/streaming-output.test.mjsCloses #1320