Repository navigation
fix: report Feasible when the split's cost stage did not prove the money - #322
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in #315: a split whose cost stage was stopped by the clock was reported as
Optimal.On the split path the reported status came from the stats of the last stage kept, the tie break. That stage is an LP under the cost stage's bound and proves itself almost always, so a cost stage cut off at its time limit still turned into
Optimal. Replaying a request from #315 with a forced split onhybridreturnedOptimalat -14.13 with a logged cost stage gap of 1.71, against a proven -12.42.Optimalnow also requires the cost stage to have proven its money; an unproven cost stage reportsFeasibleFeasibleare unchanged