Fix/issues 192 193 194 195 - #340
Open
DNight-King wants to merge 3 commits into
Open
Conversation
DepositScreen, DepositViewModel, and ApiClient.deposit() already existed but were only reachable via the deep-link action router — there was no way to open Deposit from the normal vault list/detail flow, and VaultListScreen's onVaultClick was a no-op. Add a VaultDetailScreen route wired from VaultListScreen, and a Funds section on VaultDetailScreen with a Deposit button that navigates to the existing DepositScreen.
WithdrawScreen and WithdrawViewModel already existed with biometric gating via BiometricHelper (matching the check-in pattern) and were already wired to the deep-link action router, but there was no path to them from the normal vault list/detail flow. Add a Withdraw button to VaultDetailScreen's Funds section, passing the vault's current balance so WithdrawScreen can enforce its client-side balance guard.
…arAddress ManageBeneficiaryScreen already existed but had no route or entry point anywhere in the app, and its address validation only checked for a non-empty, changed value rather than a syntactically valid Stellar StrKey address (unlike CreateVaultDialog, which already validates via StellarAddress.isValidPublicKey from ethos-protocol#113). Add a "Manage Beneficiary" button to VaultDetailScreen and a beneficiary/{vaultId} route (via a small ManageBeneficiaryRoute wrapper that loads the vault first, since ManageBeneficiaryScreen needs the full Vault for its current beneficiary). Fix the validation to reuse StellarAddress.isValidPublicKey, matching the create-vault flow.
|
@DNight-King Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires up Deposit, Withdraw, and Manage Beneficiary flows on Android — the screens, ViewModels,
and API calls already existed but were unreachable from the app's normal navigation (only from
deep links). Also fixes a validation gap in beneficiary address entry.
VaultDetailScreennavigation fromVaultListScreen(previously a no-op), with a Fundssection exposing Deposit and Withdraw, and a Beneficiary section exposing Manage Beneficiary.
ManageBeneficiaryScreento validate the new address withStellarAddress.isValidPublicKey(previously only checked non-empty/changed), matching
CreateVaultDialog's existing validation.PARITY.mdrows for Deposit, Withdraw, and Update Beneficiary.Not included
#192 (assetlinks.json verification failure) is not addressed — root cause is on the server
hosting
ethos-protocol.app, which this repo doesn't contain code for. The verification script/workflow itself looks correct. Fixing it requires updating the live
assetlinks.jsonfile or theANDROID_CERT_SHA256repo secret, not a code change here.Test plan
biometric confirmation, and returns on success
rejects a malformed Stellar address, and accepts a valid one
Closes #192
Closes #193
Closes #194
Closes #195