feat(redundancy): add redundancy level configuration for smoke check by akrem-chabchoub · Pull Request #556 · ethersphere/beekeeper

akrem-chabchoub · 2026-01-02T14:07:10Z

Smoke check redundancy level option

Summary

Adds configurable redundancy levels to the smoke check so upload/download can be tested at different r-levels (0, 2, 4). The Bee API is extended to send the Swarm-Redundancy-Level header on upload and download, and smoke metrics are extended with a redundancy_level dimension plus success/bytes counters.

What changed

Config and API

config/local.yaml – Smoke check gains r-levels: [0, 2, 4] so each file size is tested for each level.
pkg/bee/api/ – New Swarm-Redundancy-Level header:
- Upload: UploadOptions.RLevel and header set in bytes upload.
- Download: DownloadOptions.RLevel and header set in requestDataGetHeader; optional RedundancyFallbackMode used in tests.
pkg/config/check.go – New RLevels option: YAML r-levels is decoded and applied to the smoke check options.

Smoke check

pkg/check/smoke/smoke.go – Smoke runs over file sizes × redundancy levels: for each size, it iterates over r-levels, uploads with that level, then downloads with the same level (and fallback). Retries and error handling (upload skip on failure, topology logging on download failure) are preserved; metrics use a redundancy_level label.
pkg/check/smoke/metrics.go – New metrics: upload_success, download_success, uploaded_bytes_total, downloaded_bytes_total. Existing smoke metrics get a redundancy_level label. Duration histograms get extra buckets (e.g. 1800, 3600 s) for long-running runs.

Copilot

Pull request overview

This PR adds support for configuring erasure coding redundancy levels in smoke tests to enable testing of Bee's redundancy features. The implementation adds a new r-level configuration option that can be set from 0 (NONE) to 4 (PARANOID), allowing smoke tests to verify proper redundancy behavior.

Key changes:

Added RLevel field to smoke test options with configurable YAML parameter r-level
Extended upload/download test methods to accept and handle redundancy levels
Added conditional Swarm-Redundancy-Level HTTP header for uploads when redundancy is enabled
Enabled redundancy fallback mode for downloads when using redundancy levels

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/check/smoke/smoke.go	Added `RLevel` option field with default value of `redundancy.NONE` and logging of redundancy level during test execution
pkg/config/check.go	Added YAML parsing for `r-level` option with uint8-to-Level type conversion in `applyCheckConfig`
pkg/test/test.go	Updated `Upload` and `Download` methods to accept redundancy level parameter and conditionally set download options
pkg/bee/api/options.go	Added `RLevel` field to `UploadOptions` struct to pass redundancy level to API
pkg/bee/api/bytes.go	Added conditional `Swarm-Redundancy-Level` HTTP header when redundancy level is not NONE
pkg/bee/api/api.go	Added `redundancyLevelHeader` constant definition
pkg/check/load/load.go	Updated to pass `redundancy.NONE` to maintain backward compatibility for load tests
config/local.yaml	Added example configuration with `r-level: 2` (STRONG) for ci-smoke check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-02T14:11:42Z

pkg/config/check.go

+		case "RLevel":
+			if !lv.Field(i).IsNil() { // set locally
+				fieldValue := lv.FieldByName(fieldName).Elem()
+				level := uint8(fieldValue.Uint())
+				rLevel := beeRedundancy.Level(level)
+				ft, ok := ot.FieldByName(fieldName)
+				if ok {
+					v := reflect.ValueOf(rLevel)
+					if v.Type().AssignableTo(ft.Type) {
+						ov.FieldByName(fieldName).Set(v)
+					}
+				}
+			}


Missing validation for the redundancy level value. The configuration accepts any uint8 value (0-255), but only values 0-4 are valid according to the PR description. Values outside this range will silently create invalid redundancy.Level values. Consider adding validation in the applyCheckConfig function to ensure the value is within the valid range of 0-4.

I intentionally omitted validation in Beekeeper.
The Bee API validates redundancy levels, so invalid values (e.g., 5+) are rejected with clear errors.
This keeps Beekeeper future-proof: if Bee adds level 5 or higher, Beekeeper supports it without code changes.

config/local.yaml

pkg/check/smoke/smoke.go

…ltiple levels

pkg/config/check.go

…r of r-levels

…moke-redundancy-option

pkg/bee/api/api.go

pkg/bee/api/options.go

pkg/check/smoke/smoke.go

gacevicljubisa · 2026-02-19T16:32:29Z

pkg/check/smoke/smoke.go

 		UploadTimeout:   60 * time.Minute,
 		DownloadTimeout: 60 * time.Minute,
 		IterationWait:   5 * time.Minute,
+		RLevels:         []redundancy.Level{redundancy.PARANOID},


Maybe best to leave it empty (wihout specifying any level), and ensure that default behaviour is used (and that check is working like it worked before)

…uests

pkg/bee/api/api.go

pkg/bee/api/bytes.go

gacevicljubisa · 2026-03-09T12:20:27Z

pkg/test/test.go

+	if rLevel != nil && *rLevel != redundancy.NONE {
+		fallbackMode := true
+		downloadOpts = &api.DownloadOptions{
+			RLevel:                 rLevel,


RLevel should be assigned only if it is defined in the yaml file where is the configuration for the checks.

gacevicljubisa · 2026-03-09T12:22:09Z

pkg/check/load/load.go


-					address, duration, err = test.Upload(ctx, uploader, txData, batchID)
+					rLevel := redundancy.NONE
+					address, duration, err = test.Upload(ctx, uploader, txData, batchID, &rLevel)


We do not need to have default value for the rLevel, we should take it from configuration directly as is, to be backwards compatibile. If the rLevel is defined we should forward it. If not, use nil.

I think we can set it to nil and later we do proper update to load check ? because it will require some modification to the check itself, wdyt ?

pkg/check/load/load.go

gacevicljubisa · 2026-03-09T14:09:11Z

Also, we should add label for the metrics because the results depending on the specified redundancy-level. Current metrics do not have this label, so if we add it, probably we will break the current dashboards. But we can update them in Grafana. Also, /bytes endpoint, currently is using None as default for upload, but Paranoid for download. So if not specified maybe we should use that values? Wdyt?

…#575) Add redundancy_level label to all smoke check metrics to enable per-redundancy-level and per-file-size analysis in Grafana dashboards. - Add redundancy_level label to all per-operation metric vectors - Change throughput metrics from Gauge to Histogram for quantile support - Add upload_success/download_success counters - Add uploaded_bytes_total/downloaded_bytes_total counters

…o NONE

…moke-redundancy-option

gacevicljubisa · 2026-03-13T12:11:35Z

Grafana Dashboard Beekeeper - Smoke Check Performance for bee-light-testnet with this changes included

feat(redundancy): add redundancy level configuration for smoke check

e63ce38

Copilot AI review requested due to automatic review settings January 2, 2026 14:07

akrem-chabchoub self-assigned this Jan 2, 2026

Copilot started reviewing on behalf of akrem-chabchoub January 2, 2026 14:07 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

akrem-chabchoub requested review from acud, gacevicljubisa, janos and martinconic January 2, 2026 14:20

feat(redundancy): add redundancy level configuration to download

08d39c4

bcsorvasi added this to the bee-v2.7.0 milestone Jan 6, 2026

gacevicljubisa reviewed Jan 20, 2026

View reviewed changes

config/local.yaml Outdated Show resolved Hide resolved

martinconic reviewed Feb 5, 2026

View reviewed changes

pkg/check/smoke/smoke.go Outdated Show resolved Hide resolved

feat(redundancy): update redundancy level configuration to support mu…

199b519

…ltiple levels

akrem-chabchoub added redundancy smoke labels Feb 11, 2026

gacevicljubisa reviewed Feb 17, 2026

View reviewed changes

pkg/config/check.go Outdated Show resolved Hide resolved

akrem-chabchoub added 2 commits February 17, 2026 17:08

refactor(redundancy): remove deprecated r-level configuration in favo…

a00ad6c

…r of r-levels

Merge branch 'master' of github.com:ethersphere/beekeeper into feat/s…

0dae27d

…moke-redundancy-option

gacevicljubisa reviewed Feb 19, 2026

View reviewed changes

akrem-chabchoub added 2 commits March 8, 2026 23:55

fix(api): update header variable name for redundancy level in API req…

a9b0600

…uests

fix: update redundancy level handling to use pointers for options

e801457

akrem-chabchoub modified the milestones: bee-v2.7.0, 2026 Mar 9, 2026

akrem-chabchoub requested review from gacevicljubisa and martinconic March 9, 2026 09:11

chore(smoke): remove logging of redundancy levels in smoke check

c14ea9b

gacevicljubisa reviewed Mar 9, 2026

View reviewed changes

pkg/bee/api/api.go Outdated Show resolved Hide resolved

gacevicljubisa reviewed Mar 9, 2026

View reviewed changes

pkg/bee/api/bytes.go Outdated Show resolved Hide resolved

gacevicljubisa reviewed Mar 9, 2026

View reviewed changes

pkg/check/load/load.go Outdated Show resolved Hide resolved

gacevicljubisa linked an issue Mar 12, 2026 that may be closed by this pull request

[Draft] Add different file sizes to Milestone Smoke Test #504

Open

gacevicljubisa and others added 4 commits March 12, 2026 11:27

fix: simplify redundancy level checks by removing direct comparison t…

1420fcf

…o NONE

Merge branch 'master' of github.com:ethersphere/beekeeper into feat/s…

47f4a1f

…moke-redundancy-option

fix: revert back changed metrics

5581575

gacevicljubisa requested review from darkobas2 and significance March 13, 2026 12:08

darkobas2 approved these changes Mar 13, 2026

View reviewed changes

gacevicljubisa self-assigned this Mar 13, 2026

Conversation

akrem-chabchoub commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Smoke check redundancy level option

Summary

What changed

Config and API

Smoke check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

akrem-chabchoub Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gacevicljubisa Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gacevicljubisa Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

gacevicljubisa Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

akrem-chabchoub Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gacevicljubisa commented Mar 9, 2026

Uh oh!

gacevicljubisa commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

akrem-chabchoub commented Jan 2, 2026 •

edited

Loading

gacevicljubisa commented Mar 13, 2026 •

edited

Loading