Add Download .ics link to protocol call calendar comments#2012
Open
dionysuzx wants to merge 1 commit intoethereum:masterfrom
Open
Add Download .ics link to protocol call calendar comments#2012dionysuzx wants to merge 1 commit intoethereum:masterfrom
dionysuzx wants to merge 1 commit intoethereum:masterfrom
Conversation
Add build_ics_download_link() that generates a URL to the ps.ethereum.foundation /api/ics endpoint with event data as query params. Update render_calendar_comment_line() to include the new link alongside the existing View and Add to Calendar links. The .ics endpoint is a stateless route handler on ethereum/protocol-support-website (PR #10) that returns a text/calendar file download from URL params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Download .icslink alongside the existingViewandAdd to Calendarlinks in protocol call GitHub commentsbuild_ics_download_link()ingcal.pygenerates a URL to the/api/icsendpoint onps.ethereum.foundation(stateless — all event data in query params, same as the existing Google Calendar TEMPLATE link).icsendpoint is a new Next.js route handler onethereum/protocol-support-website— see Add /api/ics endpoint for calendar file downloads protocol-support-website#10Before
After
E2E test
Tested with a real GitHub comment on mobile (iOS) and desktop: dionysuzx/pm#16 (comment)
Dependencies
Test plan
test_gcal_links.py).icsdownload works on desktop browser.icsdownload works on mobile (iOS calendar app opens)