eth: accept a block hash in eth_estimateGas and eth_createAccessList - #889
Open
MysticRyuujin wants to merge 1 commit into
Open
MysticRyuujin wants to merge 1 commit into
MysticRyuujin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eth_calltakesBlockNumberOrTagOrHashfor its block parameter.eth_estimateGasandeth_createAccessListtakeBlockNumberOrTag, so the spec rejects a block hash that every client accepts (#491).This PR changes both parameters to
BlockNumberOrTagOrHashand adds one fixture per method that passes the head block hash:estimate-blockhashandcreate-al-blockhash. Both are exact-match. The estimate returns 21000 for the transfer, the same asestimate-simple-transferatlatest.make fillregenerates only the two new fixtures.make build,make test,make lintand the tools lint and test pass.#888 edits the description line of the same two parameters. The two PRs touch adjacent lines, so whichever merges second needs a trivial rebase.
Closes #491.