Conversation
jtraglia
approved these changes
Sep 24, 2026
jtraglia
left a comment
Member
There was a problem hiding this comment.
Nice, LGTM. I pushed a little nit fix, hope that's fine.
Member
|
Hey @mkalinin feel free to merge this whenever you think it's ready. I'm not sure if you want to have more reviews from others or if there's any reason to wait. Note that you'll need to click the "update branch" button & wait for the CI checks to pass, then you should be able to merge it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To calculate committee weights between slots, the existing algorithm relies on an estimate whose accuracy depends on the level of stake consolidation. This PR replaces that estimate with an exact computation, making this part of the algorithm independent of stake consolidation.
Details
Note that if a span of slots crosses an epoch boundary there can be an overlap in participating indices but the final participants set must have no duplicates. Thus, caching each committee weight and using a sum of committee weights as a result will not work in general case.
is_one_confirmedandcompute_honest_ffg_support_for_current_targetwhich use different balance sources passed to thecompute_committee_weight_between_slots.Tests
is_on_confirmedchecks are written with the help of AI but reviewed manually