Skip to content

feat: improve attachment preview cards#3786

Merged
esengine merged 3 commits into
esengine:main-v2from
Abysstsuki:feat/attachment-preview-cards
Jun 11, 2026
Merged

feat: improve attachment preview cards#3786
esengine merged 3 commits into
esengine:main-v2from
Abysstsuki:feat/attachment-preview-cards

Conversation

@Abysstsuki

Copy link
Copy Markdown
Contributor

Summary

  • Add display-name-aware attachment references so newly sent desktop messages can preserve original filenames in history.
  • Update composer attachment cards with image-first ordering, larger image thumbnails, aligned remove controls, and rectangular file cards.
  • Update user-message attachment cards to match the composer preview layout, including image thumbnail loading for stored image attachments.

Scope

This is a frontend display change only. The submitted model input still uses the existing @.reasonix/attachments/... references, and the backend attachment storage / reference resolution flow is unchanged.

Testing

  • npx.cmd tsx src/__tests__/attachment-display.test.ts
  • npm.cmd run test:typecheck
  • npm.cmd run check:css

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 10, 2026

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. The display/submit split is handled correctly — the named @[label](path) form only ever exists in the display string, the model still receives the raw @.reasonix/attachments/… refs, and the parser keeps backward compatibility with unnamed refs. baseName growing backslash awareness and the escaped-bracket cleanup in labels are the right edge cases to have covered, and sortDisplayAttachments relying on stable sort keeps non-image relative order intact.

One small thing I'll fix in a follow-up rather than another round here: attachment-display.test.ts isn't wired into the test/test:all scripts in package.json (the suite enumerates files explicitly), so CI never runs it as-is.

Merging — the composer/message card alignment is a clear visual upgrade. Thanks!

@esengine esengine merged commit 6cef84c into esengine:main-v2 Jun 11, 2026
13 checks passed
esengine added a commit that referenced this pull request Jun 11, 2026
…3954)

The explicit tsx file list in the test scripts never picked up the
test added by #3786, so CI was not running it.

Co-authored-by: reasonix <reasonix@deepseek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants