Skip to content

Bump the nuget-patch-and-minor group with 2 updates - #3130

Merged
erikdarlingdata merged 4 commits into
devfrom
dependabot/nuget/dev/nuget-patch-and-minor-ae8f6e9429
Sep 7, 2026
Merged

Bump the nuget-patch-and-minor group with 2 updates#3130
erikdarlingdata merged 4 commits into
devfrom
dependabot/nuget/dev/nuget-patch-and-minor-ae8f6e9429

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 7, 2026

Copy link
Copy Markdown
Contributor

Updated AWSSDK.PI from 4.0.100.11 to 4.0.100.12.

Release notes

Sourced from AWSSDK.PI's releases.

No release notes found for this version range.

Commits viewable in compare view.

Updated AWSSDK.RDS from 4.0.104.4 to 4.0.105.1.

Release notes

Sourced from AWSSDK.RDS's releases.

No release notes found for this version range.

Commits viewable in compare view.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps AWSSDK.PI from 4.0.100.11 to 4.0.100.12
Bumps AWSSDK.RDS from 4.0.104.4 to 4.0.105.1

---
updated-dependencies:
- dependency-name: AWSSDK.PI
  dependency-version: 4.0.100.12
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-patch-and-minor
- dependency-name: AWSSDK.RDS
  dependency-version: 4.0.105.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-patch-and-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Sep 7, 2026

Copy link
Copy Markdown
Owner

Review summary

Dependabot group bump of two AWS SDK packages in Directory.Packages.props:11-12:

  • AWSSDK.PI 4.0.100.11 → 4.0.100.12 (patch)
  • AWSSDK.RDS 4.0.104.4 → 4.0.105.1 (minor)

Both stay within the AWS SDK v4 line and cover the RDS/PI collectors that back the AWS observability path. No breaking APIs expected at this delta.

Checks

  • Base branch: dev — correct.
  • PlanAnalyzer sync: N/A — no Services/PlanAnalyzer.cs change on either side.
  • Schema/upgrades: N/A — no .sql touched.
  • Lite-first ordering: N/A — dependency bump only.
  • SignPath/build: N/A — .github/workflows/build.yml unchanged; signing profile stays test-signing.
  • Test coverage: N/A — no logic change.

Attention

Nothing blocking. Worth a quick sanity build + a run of Lite.Tests to confirm the RDS/PI collector shapes still bind — AWS SDK minor bumps have occasionally shuffled model classes even within a major.


Generated by Claude Code

Copy link
Copy Markdown
Owner

CI failure — Darling whole-tree guards

The dotnet restore --locked-mode on Darling/Darling.Tests/Darling.Tests.csproj fails because Dependabot bumped the AWSSDK versions in Directory.Packages.props but didn't regenerate the packages.lock.json files:

error NU1004: Mistmatch between the requestedVersion of a lock file dependency marked as
CentralTransitive and the version specified in the central package management file.
Lock file version [4.0.100.11, ), central package management version [4.0.100.12, ).

Root cause is this PR's diff (the AWSSDK.PI/AWSSDK.RDS bumps); it's not an infra flake or an unrelated failure.

Fix: regenerate the affected lock files with dotnet restore --force-evaluate (start with Darling/Darling.Tests — the log stopped at the first project, so other projects transitively referencing AWSSDK.PI/RDS may also need it) and commit the updated packages.lock.json files. Or, if you want the bot to redo it, ·@·d·ependabot r·ecreate to reroll the PR with fresh locks.

Per my review posture I'm not pushing anything — flagging for the maintainer.


Generated by Claude Code

@erikdarlingdata

Copy link
Copy Markdown
Owner

Claude posting for Erik Darling

This is red on NU1004 because Dependabot moves Directory.Packages.props and does not regenerate the packages.lock.json files that go with it. One command on this branch clears it:

dotnet restore PerformanceMonitor.sln --force-evaluate

then commit the lock files it rewrites. On a CRLF checkout that is Darling/Darling.Tests/packages.lock.json only — seven lines, AWSSDK.PI 4.0.100.11 -> .12 and the AWSSDK.Core 4.0.102.1 -> .3 it pulls with it. A restore run on Linux or macOS also rewrites the other eight lock files with LF; git normalises those away on add.

Worth knowing while this sits: Darling whole-tree guards is not a required check on dev, so this pull request reads UNSTABLE rather than BLOCKED — it is mergeable today, with lock files that do not match the props file it ships. #3147 makes the required build check able to report the mismatch, which it could not before.

Restore in locked mode fails NU1004 when Directory.Packages.props moves a
CentralTransitive version and the lock file still pins the previous range.
@claude

claude Bot commented Sep 7, 2026

Copy link
Copy Markdown

Reviewed. This is a routine dependabot dependency bump (AWSSDK.PI 4.0.100.11→4.0.100.12, AWSSDK.RDS 4.0.104.4→4.0.105.1) plus a lock-file regeneration commit to fix an NU1004 restore failure in Darling.Tests. No T-SQL/collector code is touched, so the style conventions don't apply. AWSSDK is Darling-only (used for RDS/PI cloud metrics) with no Lite counterpart, so there's no parity drift here. Version bumps in Directory.Packages.props and the lock file are consistent. No correctness, security, or performance concerns found.

@claude

claude Bot commented Sep 7, 2026

Copy link
Copy Markdown

Reviewed. This is a routine Dependabot patch bump (AWSSDK.PI 4.0.100.11→4.0.100.12, AWSSDK.RDS 4.0.104.4→4.0.105.1) plus the corresponding Darling/Darling.Tests/packages.lock.json regeneration (including the transitive AWSSDK.Core bump to 4.0.102.3). No T-SQL, application logic, or collector code is touched, so there's nothing to check against the style guide. No Lite/Darling parity concerns — this only affects Darling's test lockfile and the shared central package versions file, and Lite doesn't consume these AWS packages. No security or performance impact. LGTM.

@claude

claude Bot commented Sep 7, 2026

Copy link
Copy Markdown

Reviewed. This is a routine Dependabot patch bump (AWSSDK.PI 4.0.100.11→4.0.100.12, AWSSDK.RDS 4.0.104.4→4.0.105.1), touching only Directory.Packages.props and the Darling.Tests lockfile. No T-SQL, application code, or Lite/Darling parity surface is touched, so none of the review focus areas (correctness, parity drift, security, performance) apply here. No concerns — looks safe to merge.

@erikdarlingdata
erikdarlingdata merged commit feba2de into dev Sep 7, 2026
8 checks passed
@erikdarlingdata
erikdarlingdata deleted the dependabot/nuget/dev/nuget-patch-and-minor-ae8f6e9429 branch September 7, 2026 23:04
erikdarlingdata added a commit that referenced this pull request Sep 7, 2026
Directory.Packages.props conflicted because #3130 bumped the AWS SDK versions in the
same ItemGroup region. Resolved to the newer version of each package on both sides:
AWSSDK.PI 4.0.100.12, AWSSDK.RDS 4.0.105.1, BlackwellSystems.Gcf 1.0.0. The lock file
is generated, so it was resolved by regenerating it against the merged props rather
than by choosing a side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant