tsan: investigate and fix TSAN failure for createJsonFormatter StatusOr change#45836
Closed
Copilot wants to merge 1 commit into
Closed
tsan: investigate and fix TSAN failure for createJsonFormatter StatusOr change#45836Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for tsan
tsan: investigate and fix TSAN failure for createJsonFormatter StatusOr change
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #45831 changes
SubstitutionFormatStringUtils::createJsonFormatterreturn type fromFormatterPtrtoabsl::StatusOr<FormatterPtr>, and the TSAN CI job failed during that run (exit code 3 — test failure, not build failure).Investigation
The session exhausted quota before a conclusive root cause was identified or a code fix implemented. Key findings from the analysis:
ci-report-tsan.jsonartifact contained only disk usage stats; the EngFlow BES invocation URL was not reachable externally.StatusOrchanges and the TLSread_disabled_logic introduced in main atdf2c77d(tls: fix connection close detection while handshake is waiting), which ships a newAsyncCertSelectionCancellationObservedOnDownstreamCloseintegration test.CancellableSelectionHandledestructor inasync_cert_selector.hholds anEvent::TimerPtrandCertificateSelectionCallbackPtr; if destroyed off the dispatcher thread (e.g., when the downstream connection closes and tears downSslExtendedSocketInfoImpl), TSAN would flag it as a data race.Status
CancellableSelectionHandledestruction threading hypothesis