Skip to content

refactor: remove unreachable legacy partial-pagination cache-fallback branch#1296

Open
sxxtony wants to merge 1 commit into
entrius:testfrom
sxxtony:fix/remove-unreachable-cache-fallback-branch
Open

refactor: remove unreachable legacy partial-pagination cache-fallback branch#1296
sxxtony wants to merge 1 commit into
entrius:testfrom
sxxtony:fix/remove-unreachable-cache-fallback-branch

Conversation

@sxxtony
Copy link
Copy Markdown

@sxxtony sxxtony commented May 17, 2026 •
edited
Loading

Summary

  • remove unreachable legacy partial-pagination branch in store_or_use_cached_evaluation
  • keep existing cache fallback behavior for current mirror/identity fetch-failure paths
  • update method docstring wording to reflect mirror-only flow

Related Issues

Fixes #1295

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Testing

  • Tests added/updated
  • Manually tested

Validated with:

  • uv run pytest -q tests/validator/test_github_identity_fallback.py
  • uv run pytest -q tests/validator/oss_contributions/mirror/test_routing.py

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Changes are documented (if applicable)

@xiao-xiao-mao xiao-xiao-mao Bot added the refactor Code restructuring without behavior change label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactor Code restructuring without behavior change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor: remove unreachable legacy partial-pagination cache-fallback branch in store_or_use_cached_evaluation

1 participant

@sxxtony