fix: subprocess isolate to close timeout-immune tree-sitter hang#1290
Open
seroperson wants to merge 1 commit into
Open
fix: subprocess isolate to close timeout-immune tree-sitter hang#1290seroperson wants to merge 1 commit into
seroperson wants to merge 1 commit into
Conversation
seroperson
force-pushed
the
treesitter-security
branch
from
fe4f8f4 to
69fbd9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1289
Summary
multiprocessing.Pool(processes=1)with a hardSCORING_SUBPROCESS_BUDGET_S = 5.0s wall-clock. On timeout or worker crash the worker is killed and the PR is zero-scored withscoring_method='skipped-isolation-timeout'; the round continues.atexithook (isolated_scoring.shutdown) so themultiprocessingresource_tracker does not log spurious leaked-semaphore warnings.Follow-up to #1276.
Type of Change
Testing
Existing tests cover the subprocess isolation, but I've added several more to ensure timeout hanging works correctly.