fix: route configured null-language extensions to line-count instead of skipped-unsupported (#1274)#1278
Open
alpurkan17 wants to merge 1 commit into
Open
Conversation
…of skipped-unsupported (entrius#1274)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extensions in
programming_languages.jsonwithlanguage=null(no tree-sitter parser) receivescore=0.0withscoring_method=skipped-unsupported. The scorer only routed to line-count when the extension appeared inNON_CODE_EXTENSIONS— it never consulted the JSON config for null-language entries.This affects 11 extensions:
env,gitattributes,gitignore,gql,graphql,ipynb,move,nim,pde,puml,tex.Fix: add an inline check before the
skipped-unsupportedgate: when the extension is configured inprogramming_languageswithlanguage=null, route to line-count scoring using the configured weight. No new method, no import changes — single inline check in the existing elif chain.Validation
uv run ruff check— cleanuv run ruff format --check— cleanuv run pyright— 0 errors / 0 warningsuv run pytest tests/ -k "null_language or line_count" -q— 30/30 passedCloses #1274