fix: reject GraphQL viewer:null in gitt miner post local PAT preflight (#1195)#1196
Closed
alpurkan17 wants to merge 4 commits into
Closed
fix: reject GraphQL viewer:null in gitt miner post local PAT preflight (#1195)#1196alpurkan17 wants to merge 4 commits into
alpurkan17 wants to merge 4 commits into
Conversation
10 tasks
anderdc
previously approved these changes
May 14, 2026
Collaborator
anderdc
left a comment
There was a problem hiding this comment.
Mirrors the validator-side viewer:null check at pat_handler.py:189. Small UX win on the preflight path.
Contributor
Author
|
@anderdc this PR is approved — mind hitting merge when you get a chance? Thanks! |
…ntrius#1276) Co-authored-by: anderdc <me@alexanderdc.com>
…e_at (entrius#1285) Co-authored-by: anderdc <me@alexanderdc.com>
Contributor
Author
Contributor
Author
|
@anderdc review was dismissed — could you please re-review? The diff is +7 lines unchanged (post.py); the rest is from upstream merge commits. |
Collaborator
|
Duplicate of #1197, which is better scoped and implemented — it ports the full validator-side check (errors, data, viewer:null) in a clean 2-file diff with regression tests. This PR is conflicting, its 20-file diff is dominated by unrelated pioneer/scoring changes, and it only adds the viewer:null check while missing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The local PAT preflight only checks the GraphQL HTTP status code, but validators reject fine-grained PATs that return
data.viewer: null(validator-side fix #764). Miners see a false "PAT valid" locally and broadcast tokens that validators deterministically reject.Port the
viewer:nullcheck frompat_handler.py:189to the CLI preflight so both paths reject the same response shapes.Validation
uv run ruff check— cleanuv run ruff format --check— cleanuv run pyright— 0 errorsuv run pytest tests/cli/test_miner_commands.py -q— passedCloses #1195