fix(queue): evict failed PR_FILES jobs so retries are not blocked#125
Closed
Yurii214 wants to merge 1 commit into
Closed
fix(queue): evict failed PR_FILES jobs so retries are not blocked#125Yurii214 wants to merge 1 commit into
Yurii214 wants to merge 1 commit into
Conversation
Closes entrius#124 Mirror PR_METADATA (entrius#118): use removeOnFail: true on PR_FILES enqueue sites so a failed fetch-pr-files job does not retain the deterministic jobId and block later refreshes for the same SHA tuple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
Summary
removeOnFail: trueonPR_FILESenqueue inpull-request.handler.tsandfetch.processor.tsPR_METADATAjobsWhy
Failed
fetch-pr-filesjobs retained withremoveOnFail: 50squat on the deterministic jobId and block later refreshes for the same SHA tuple (e.g. base-retarget after #115).Test plan
npm run lintpassesnpm run buildpasses