test(e2e): bump resume checkpoint-advance timeout to 60s for CI flakiness - #1902
Closed
gtrrz-victor wants to merge 1 commit into
Closed
test(e2e): bump resume checkpoint-advance timeout to 60s for CI flakiness#1902gtrrz-victor wants to merge 1 commit into
gtrrz-victor wants to merge 1 commit into
Conversation
TestResumeSquashMergeMultipleCheckpoints flaked on the git-branch canary with "checkpoint state did not advance from <ref> within 30s". The second checkpoint condenses onto the single entire/checkpoints/v1 branch, whose advance can lag on a loaded CI runner; the same run passed on rerun with no code change. 30s reduced but did not eliminate the flake (#787 moved this class 15s->30s); give the two waits in this test 60s. CI-timing only, no production change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR de-flakes the Vogon canary E2E test TestResumeSquashMergeMultipleCheckpoints by increasing checkpoint-advance polling timeouts to better tolerate slower CI runners, without changing production behavior.
Changes:
- Increase
WaitForCheckpointtimeout from 30s → 60s inTestResumeSquashMergeMultipleCheckpoints. - Increase
WaitForCheckpointAdvanceFromtimeout from 30s → 60s in the same test. - Add an explanatory comment describing why CI may need the longer poll window.
Comment on lines
+89
to
+92
| // The second checkpoint condenses onto the single git-branch v1 branch, | ||
| // whose advance can lag on a loaded CI runner. 30s flaked here | ||
| // intermittently (only on the git-branch backend); give it 60s. See #787 | ||
| // for the same CI-slower-than-local timing class. |
gtrrz-victor
marked this pull request as draft
August 5, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/977
De-flakes
TestResumeSquashMergeMultipleCheckpointson the Vogon canary.Failing job
test-canary (git-branch) — run 30997514111, attempt 1
It surfaced on #1896's CI and passed on attempt 2 with no code change — a timing flake, not a regression. The
testjob failure in the same run is a cascade (needs: test-canary).Root cause
The second checkpoint condenses onto the single
entire/checkpoints/v1branch. That advance is normally inline in the post-commit hook, but on a loaded CI runner it can lag behind the 30s poll window.#787already moved this class 15s→30s for the same "CI slower than local" reason; this test still occasionally exceeds 30s.Not reproducible locally (20/20 on the git-branch backend) — the local machine is too fast to lose the race.
Change
Bump the two checkpoint waits in this test (30s → 60s). Test-timing only; no production code touched.
Out of scope (noted, not fixed here)
A separate latent bug: git-branch
setPrimaryRefadvances the shared v1 branch with a read-tip-then-set-ref and no compare-and-swap (checkpoint/persistent.go), so genuinely concurrent checkpoint writers could clobber v1. Not reachable in this single-session test (no concurrent writer); worth its own issue.🤖 Generated with Claude Code
Note
Low Risk
E2E test timeout and comment changes only; no production or security impact.
Overview
Addresses intermittent CI failures in
TestResumeSquashMergeMultipleCheckpointson the git-branch backend, where checkpoint state sometimes did not advance within the previous 30s poll window on loaded runners.WaitForCheckpointandWaitForCheckpointAdvanceFromin that test are increased to 60s, with comments tying the flake to lag when the second checkpoint condenses onto the sharedentire/checkpoints/v1branch (same timing class as #787). Test-only change; no production behavior.Reviewed by Cursor Bugbot for commit 1571da8. Configure here.