Quiet, threshold-gated pre-push checkpoint progress (supersedes #1684)

[gtrrz-victor]

https://entire.io/gh/entireio/cli/trails/965

Problem / intent

Supersedes #1684 (builds on @SnowingFox's work — kept as co-author).

The pre-push checkpoint sync can sit for a while (fetch, replay, retry), so a slow push feels stuck. #1684 addressed this with phased progress + a session tree, but since then git-refs became the default checkpoint backend:

1. The default path is now flushCheckpointRefsQueue (git-refs), which Add detailed checkpoint push progress during pre-push #1684's session-tree UX didn't cover — it emitted an unconditional [entire] Pushing N checkpoint ref(s)... line + dot spinner.
2. Most git pushes are run by agents and CI, which never read that stderr — so progress there is pure terminal noise.

Principle: useful to a human at a terminal, silent for everyone else.

Approach

• pushReporter (new): gated on interactive.ShouldStyle — a non-TTY / NO_COLOR / cygwin writer receives zero bytes. On a styled terminal it reveals a single in-place line after ~1s (sub-1s pushes stay silent).
• Live transfer + count: the revealed line streams git's own --progress stats in real time, alongside the checkpoint count and elapsed:

  [entire] syncing 12 checkpoints… writing 40/47 objects (3s)
  [entire] pushed 12 checkpoints (4s)
  

• Divergence recovery (batch push rejected non-fast-forward → per-ref fetch+replay+push) shows an advancing counter:

  [entire] syncing checkpoint 5/24 with remote… (18s)
  

• Transfer detail → file logs (.entire/logs/, operational metadata only) on both backends regardless of TTY.
• Legacy git-branch path also silenced for non-TTY; error / auth-hint lines always print.
• Push semantics unchanged — display only, fast-forward-only, never blocks the push.

Result

Who / when	Terminal output
Agent / CI / non-TTY / NO_COLOR	nothing (detail still in .entire/logs/)
TTY, sub-1s push	nothing
TTY, slow push	live line (count + transfer + elapsed) → persistent pushed N
Divergence recovery	syncing i/N with remote counter
Any error / auth hint	always printed

Test plan

• pushReporter: non-TTY/unstyled writes nothing; reveal → live detail → persistent summary; empty-summary clears; deterministic (no time.Sleep), race-clean
• live git --progress streamer: chunk-split parsing
• git-refs path: non-TTY emits no progress while refs land + queue drains
• logGitProgress: file-logs on both backends, no terminal writes (real fd-capture guard)
• git-branch path: non-TTY silent, error/hint lines still print
• Cursor Bugbot + Copilot review comments addressed (session-tree trailer bug, ShouldStyle gating, test isolation, session-tree styling, duplicate transfer line, flaky test)
• mise run fmt, lint (golangci-lint v2.11.3), full -race suite — CI green

🤖 Generated with Claude Code

---

Note

Low Risk
Display and logging only around existing push/sync paths; push semantics and error handling boundaries are explicitly preserved with new regression tests.

Overview
Reworks pre-push checkpoint progress so agents/CI see no stderr noise while interactive pushes get clearer, less chatty feedback. Push behavior (fast-forward-only, fail-soft) is unchanged.

git-refs path: Replaces the unconditional “Pushing N ref(s)…” banner and dot spinner with a pushReporter that writes nothing unless stderr is a TTY and the sync runs longer than ~2s, then shows one in-place line that clears on completion.

git-branch (v1) path: Routes phased “Pushing / Syncing / done” lines and the session-tree summary through pushProgressOutput() (TTY-only); warnings and hints (SSH auth, protected refs, sync failures) still go to os.Stderr unconditionally. fetchAndRebaseRefCommon can stream fetch/rebase sub-steps to the progress writer and reports cherry-pick progress via an optional callback on cherryPickOnto.

Git push plumbing: PushWithOptions adds --progress and splits stdout/stderr; callers parse stderr for human display (displayGitProgress) and always file-log transfer phases via logGitProgress (including when the terminal is gated off).

Tests lock in non-TTY silence, actionable errors still printing, and log-only progress capture.

^{Reviewed by Cursor Bugbot for commit 43605ba. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 4 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 43605ba. Configure here.}

[Copilot]

Pull request overview

This PR refines pre-push checkpoint sync UX to be silent for non-interactive environments (agents/CI) while still providing threshold-gated, in-place progress feedback for humans on a TTY, and moves detailed git transfer progress into .entire/logs/ for debuggability.

Changes:

• Introduces a TTY- and time-threshold-gated pushReporter for git-refs checkpoint pushes (no scrollback residue; zero bytes on non-TTY).
• Reworks legacy git-branch progress output to be TTY-only while preserving unconditional actionable warnings/hints.
• Captures/parses git push --progress stderr for file logging on both backends and selectively displays human-friendly transfer summaries on TTY.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
cmd/entire/cli/strategy/push_reporter.go	Adds threshold-gated, in-place progress reporter (TTY-only) for pre-push checkpoint sync.
cmd/entire/cli/strategy/push_reporter_test.go	Adds tests for reporter silence on non-TTY and reveal/clear behavior on TTY.
cmd/entire/cli/strategy/push_progress.go	Adds parsing/formatting for session summaries and git transfer progress; adds file logging helper.
cmd/entire/cli/strategy/push_progress_test.go	Adds tests for push summary parsing/tree formatting and git --progress parsing/logging behavior.
cmd/entire/cli/strategy/push_common.go	Wires progress gating for legacy git-branch backend; adds file logging of git transfer progress.
cmd/entire/cli/strategy/push_common_test.go	Updates tests to assert non-TTY silence while warnings still print; adds regression guard for file-logged progress.
cmd/entire/cli/strategy/metadata_reconcile.go	Extends cherry-pick helper to optionally report replay progress (current/total).
cmd/entire/cli/strategy/manual_commit_push.go	Wires git-refs queue flushing to pushReporter; adds session-summary printing on TTY.
cmd/entire/cli/strategy/manual_commit_push_test.go	Adds non-TTY regression test ensuring git-refs queue push remains silent while still pushing refs.
cmd/entire/cli/strategy/common.go	Updates cherry-pick helper call sites for the new optional progress callback parameter.
cmd/entire/cli/checkpoint/remote/git.go	Splits git push stdout/stderr capture and always enables --progress for parsing/logging.