chore: commit generated worker types in flue-review and playground - #2392
Conversation
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | 0fb3c04 | Aug 12 2026, 12:04 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | 0fb3c04 | Aug 12 2026, 12:03 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-do | 0fb3c04 | Aug 12 2026, 12:04 PM |
Scope checkThis PR changes 28,986 lines across 4 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Removes .gitignore rules that previously excluded worker-configuration.d.ts in two worker packages, with the intent of committing the generated Wrangler type declarations so fresh checkouts and CI have the correct ambient worker types.
Changes:
- Stop ignoring
worker-configuration.d.tsininfra/flue-review - Stop ignoring
worker-configuration.d.tsindemos/playground
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| infra/flue-review/.gitignore | Removes ignore rule so generated worker types can be committed/tracked |
| demos/playground/.gitignore | Removes ignore rule so generated worker types can be committed/tracked |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| .wrangler/ | ||
| .flue-vite/ | ||
| .flue-vite*.wrangler.jsonc | ||
| worker-configuration.d.ts | ||
| .dev.vars |
| dist/ | ||
| .astro/ | ||
| .wrangler/ |
github-actions
Bot
added
the
review/awaiting-author
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
![emdashbot[bot]](https://avatars.githubusercontent.com/in/3255304?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approach: this is the right change. EmDash already commits worker-configuration.d.ts in nine other worker packages, and gitignoring it meant CI type-aware lint and fresh worktrees lacked the ambient Env/runtime declarations. Committing the generated files for demos/playground and infra/flue-review aligns them with the rest of the repo and addresses the missing-Env/RequestInfo-as-any errors described in the PR.
I inspected the generated files, the .gitignore removals, the tsconfig.json references, and sibling worker-package conventions. Both files contain only binding shapes and secret/variable names — no secret values are leaked (the GITHUB_APP_ID/GITHUB_APP_INSTALLATION_ID values in the flue-review file are public Wrangler vars explicitly documented as non-secret in wrangler.jsonc). I also verified that .oxfmtrc.json already ignores worker-configuration.d.ts, so format no-ops on them.
Headline conclusion: one real gap. infra/flue-review/tsconfig.json already references the new file in its include, but demos/playground/tsconfig.json does not. AGENTS.md explicitly instructs: "Reference it in tsconfig.json's include", and the sibling Astro/Cloudflare demos (demos/cloudflare, demos/preview) both include it. Until demos/playground does the same, astro check will not load the ambient Env types, so the committed file does not fully solve the stated problem in that package.
Findings
-
[needs fixing]
demos/playground/tsconfig.json:6This
includelist omits the newly committedworker-configuration.d.ts. AGENTS.md says to "Reference it intsconfig.json'sinclude" when generating this file, and the sibling Astro/Cloudflare demos (demos/cloudflare/tsconfig.json,demos/preview/tsconfig.json) both include it. Without adding it to the TypeScript project,astro checkin this package will not load the ambientEnvand runtime types, so committing the file does not actually fix the missing-Env/type-aware lint errors this PR targets."include": ["src", ".astro/types.d.ts", "emdash-env.d.ts", "worker-configuration.d.ts"]
github-actions
Bot
added
review/needs-rereview
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | d816a5c | Aug 12 2026, 11:39 AM |
What does this PR do?
Commits the generated
worker-configuration.d.tsininfra/flue-reviewanddemos/playground, and removes the.gitignoreentries that hid it. Every other worker package in the repo commits this file (both bots aside, nine packages do); these two — plusinfra/emdash-bot, fixed on the bot next-gen stack — were the only ones ignoring it, which left CI's type-aware lint and fresh checkouts running without the workers ambient types. That is what caused theRequestInfo-as-anylint failure on #2382 and the missing-Envtypecheck errors in fresh worktrees.The generated files contain binding shapes and secret names only, no values.
Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.Tests, changeset, and i18n are n/a: the change adds generated type declarations and removes two
.gitignorelines in private packages — no runtime behavior, no published package. Typecheck n/a for the same reason (the files are inputs to typechecking, not subjects of it);pnpm lintverified on the touched packages.AI-generated code disclosure
wrangler typesoutput.Screenshots / test output
Try this PR
Open a fresh playground →
A full working EmDash site, deployed from this branch. Each visit gets its own session-scoped sandbox: no login needed and no shared state. Try the admin, edit content, hit the public site.
Tracks
chore/commit-worker-types. Updated automatically when the playground redeploys.