grpc: mark :gun and :mint as optional dependencies#525
Open
dcrck wants to merge 4 commits intoelixir-grpc:masterfrom
Open
grpc: mark :gun and :mint as optional dependencies#525dcrck wants to merge 4 commits intoelixir-grpc:masterfrom
dcrck wants to merge 4 commits intoelixir-grpc:masterfrom
Conversation
This commit marks `:grpc`'s HTTP client adapters (`:gun` and `:mint`) as optional dependencies. This is a common pattern among similar libraries, since most users will only use one HTTP client and fewer dependencies is generally a good thing. This commit also adds missing adapter tests to the `interop` script that runs in CI.
polvalente
reviewed
Apr 23, 2026
polvalente
reviewed
Apr 23, 2026
polvalente
reviewed
Apr 23, 2026
polvalente
reviewed
Apr 23, 2026
polvalente
reviewed
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit marks
:grpc's HTTP client adapters (:gunand:mint) as optional dependencies. This is a common pattern among similar libraries, since most users will only use one HTTP client and fewer dependencies is generally a good thing.This commit also adds missing adapter tests to the
interopscript that runs in CI.Closes #524
I don't know if the script changes I made are how you're supposed to do it, but it's my best guess since I can't seem to run them locally. We'll see if it works!