VAutoHider: keep a list of children - #930
Draft
danirabbit wants to merge 5 commits into
Draft
Conversation
zeebok
approved these changes
Apr 2, 2026
lenemter
reviewed
Apr 3, 2026
Comment on lines
+10
to
+15
| private List<unowned Gtk.Widget> children; | ||
| private Gtk.Label more_label; | ||
| private Gtk.Box main_box; | ||
|
|
||
| construct { | ||
| children = new List<unowned Gtk.Widget> (); |
Member
There was a problem hiding this comment.
Suggested change
| private List<unowned Gtk.Widget> children; | |
| private Gtk.Label more_label; | |
| private Gtk.Box main_box; | |
| construct { | |
| children = new List<unowned Gtk.Widget> (); | |
| private List<unowned Gtk.Widget> children = new List<unowned Gtk.Widget> (); | |
| private Gtk.Label more_label; | |
| private Gtk.Box main_box; | |
| construct { |
danirabbit
marked this pull request as draft
April 9, 2026 19:17
…er-children Conflicts: src/Grid/VAutoHider.vala
Member
|
@danirabbit I resolved conflicts here. Is there any reason this is in draft? Do we want to apply suggestion from @lenemter? |
Member
Author
|
I guess I don't know that this really solves anything. I hadn't gotten to a solution in GTK4 that was actually working so wasn't sure if this was the right direction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no
get_childrenin GTK4, so keep our own list of children becauseobserve_childrenis supposedly expensive