Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build-view.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: 20
cache: npm
cache-dependency-path: package-lock.json

- name: Setup Python
if: ${{ !matrix.self_hosted }}
Expand All @@ -101,7 +103,7 @@ jobs:
run: npm install -g bun

- name: Install Dependencies
run: npm install
run: npm ci

# Verify Electron installation on macOS
- name: Verify Electron Installation (macOS)
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: 20
cache: npm
cache-dependency-path: package-lock.json

- name: Setup Python
if: ${{ !matrix.self_hosted }}
Expand All @@ -96,7 +98,7 @@ jobs:
run: npm install -g bun

- name: Install Dependencies
run: npm install
run: npm ci

# Verify Electron installation on macOS
- name: Verify Electron Installation (macOS)
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
list-files: json
filters: |
change:
- 'package-lock.json'
- 'yarn.lock'
- 'pnpm-lock.yaml'

Expand All @@ -35,7 +34,6 @@ jobs:
let workflowFailMessage = "It looks like you've modified some files that we can't accept as contributions."
try {
const badFilesArr = [
'package-lock.json',
'yarn.lock',
'pnpm-lock.yaml',
]
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/pre-build-view.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: 20
cache: npm
cache-dependency-path: package-lock.json

- name: Setup Python
if: ${{ !matrix.self_hosted }}
Expand All @@ -106,7 +108,7 @@ jobs:
run: npm install -g bun

- name: Install Dependencies
run: npm install
run: npm ci

# Verify Electron installation on macOS
- name: Verify Electron Installation (macOS)
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/pre-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: 20
cache: npm
cache-dependency-path: package-lock.json

- name: Setup Python
if: ${{ !matrix.self_hosted }}
Expand All @@ -101,7 +103,7 @@ jobs:
run: npm install -g bun

- name: Install Dependencies
run: npm install
run: npm ci

# Verify Electron installation on macOS
- name: Verify Electron Installation (macOS)
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 20
cache: npm
cache-dependency-path: package-lock.json

- name: Install frontend dependencies
run: npm install --ignore-scripts
run: npm ci --ignore-scripts

- name: Install uv
uses: astral-sh/setup-uv@v5
Expand Down Expand Up @@ -67,9 +69,11 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 20
cache: npm
cache-dependency-path: package-lock.json

- name: Install frontend dependencies
run: npm install --ignore-scripts
run: npm ci --ignore-scripts

- name: Run type check
run: npm run type-check
Expand Down Expand Up @@ -146,9 +150,11 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 20
cache: npm
cache-dependency-path: package-lock.json

- name: Install frontend dependencies
run: npm install --ignore-scripts
run: npm ci --ignore-scripts

- name: Install Electron runtime
run: npm rebuild electron
Expand Down
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ backend/context_files/
*.sln
*.sw?

#lockfile
package-lock.json
#lockfile (package-lock.json is committed; npm ci installs from it)
pnpm-lock.yaml
yarn.lock
/test-results/
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,8 @@ To run the application locally in developer mode:

Whenever you add, update, or delete any dependencies in `pyproject.toml`, please run `uv lock` to synchronize the dependencies with the lock file.

Whenever you add, update, or delete any dependencies in `package.json`, run `npm install` and commit the updated `package-lock.json` in the same pull request. CI installs with `npm ci`, which fails when the two files don't match.

## Giving Credit 🎉

If your contribution has been included in a release, we'd love to give you credit on Twitter, but only if you're comfortable with it!
Expand Down
Loading
Loading