Repository navigation
feat: record meetings and add their notes to any Space - #2158
Open
Douglasymlai wants to merge 4 commits into
Open
Douglasymlai wants to merge 4 commits into
Douglasymlai wants to merge 4 commits into
Conversation
1 of 8 tasks
First working version of Meetings (docs/meeting-notes-plan.md §10): - Meetings library in the Home sidebar: grouped by day, search, New meeting and Import recording. - Microphone recording in the renderer. The main process checks the OS permission and asks on macOS first; a denied, missing or busy microphone is explained, with Open System Settings, and never throws. - A recording indicator on every page, pause/resume/stop, typed notes with their time, and a close/quit guard that saves the recording. - Meeting page with an editable note, typed notes and playback. - Add to Space writes Meetings/<date> <title>.md into the Space folder, tracks a digest, offers Update copy, and asks before replacing a file that was edited in the Space. Deleting keeps Space copies. - Backend store at ~/.eigent/meetings (meetings.sqlite + recordings), /meetings routes behind local control, recovery of interrupted recordings. - NSMicrophoneUsageDescription and the audio-input entitlement. The plan doc now records where this version differs: capture runs in the renderer (microphone only) until the Apple bridge lands, so system audio, transcription and model-written notes are left for later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Douglasymlai
marked this pull request as ready for review
November 19, 2026 10:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
N/A — maintainer-directed work; no linked issue required for this PR.
Description
Problem
People hold meetings on Zoom, Meet, Teams or in the room, and then retype what was decided before Eigent can help with the follow-up. Eigent could not record a meeting, and there was no place to keep meeting notes that several Spaces can use.
What this adds
A first working version of Meetings, a library next to Spaces (plan:
docs/meeting-notes-plan.md, §10 describes this version).systemPreferences.getMediaAccessStatus) and on macOS asks for it (askForMediaAccess), which shows the system prompt the first time.Meetings/<YYYY-MM-DD> <title>.mdinto the Space folder, with front matter, the note and the typed notes, so it shows in Files and Sessions can use it. Eigent stores a digest of each copy:~/.eigent/meetings/:meetings.sqlite(meetings, notes, Space links) andrecordings/<meeting id>/. Nothing is synced. Logs hold meeting ids only, never titles or notes. A meeting left Recording after a crash or reload becomes Interrupted and keeps what was saved.NSMicrophoneUsageDescriptioninmac.extendInfoand thecom.apple.security.device.audio-inputentitlement for the hardened runtime.Backend: new
backend/app/meetings/(store, note rendering, Space copy) and/meetingsroutes behind the local-control check, like the other local routes.Plan changes (in this PR,
docs/meeting-notes-plan.md§10.2). The plan puts capture in the Swift bridge from the Apple Intelligence models plan (#2157), which isn't onmainyet. So this version records the microphone in the renderer (getUserMedia+MediaRecorder). That also makes microphone recording work on Windows and Linux, where the plan offered import only. System audio, live transcription and model-written notes wait for the bridge. The plan doc also records the changed routes (a recording upload/download route; pause/resume stay in the renderer) and the tables left for later.Not done yet
Testing Evidence (REQUIRED)
CI: all 11 checks pass on
980fd883(Python tests, frontend guardrails, pre-commit, CodeQL, markdown lint, Electron preview and stream-relay tests, web + local Brain smoke).Automated, also run locally on Windows:
uv run pytest tests/app/meetings tests/app/controller/test_meeting_controller.py— 22 passed (store, recovery of interrupted recordings, search, file names, Space copy never overwriting an edited or foreign file, path containment, routes, local-control auth, import format check, delete keeping Space copies). Pre-commit (ruff, ruff-format, bandit) clean.npm run type-check, ESLint on changed files,npm run check:design-tokens,scripts/check-electron-access.sh, i18n locale parity, markdownlint.Not yet done: manual checks on real machines and screenshots. A tester should go through the checklist below and attach screenshots.
What a tester should check
macOS (signed build): first New meeting shows the consent reminder, then the macOS microphone prompt naming Eigent. Allow → recording starts, the pill shows in the corner on every page. Deny → explained, Open System Settings opens Privacy & Security → Microphone, the app doesn't crash. Turn access back on and record again. Record, pause, resume, add typed notes, stop; play back the recording. Quit (⌘Q) while recording → asked first; after confirming, the meeting is saved. Add to two Spaces, check
Meetings/…mdin Files, edit the note → Update copy; edit the file in the Space → Eigent asks before replacing. Delete the meeting → Space files remain.Windows: with Settings → Privacy → Microphone off for desktop apps, New meeting explains the denial and Open System Settings opens the microphone privacy page. With it on, record, stop, play back. Close the window while recording → asked first.
Linux: record with a microphone; unplug it mid-recording → "The microphone was disconnected", what was recorded is saved. With no microphone → "No microphone was found".
All: import an m4a/mp3, check the library groups and search, light and dark themes, and that
~/.eigent/meetings/holdsmeetings.sqliteandrecordings/<id>/.I have included human-verified testing evidence in this PR.
This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
No frontend/UI changes in this PR.
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement
🤖 Generated with Claude Code