Skip to content

feat: record meetings and add their notes to any Space - #2158

Open
Douglasymlai wants to merge 4 commits into
mainfrom
feat/meeting-notes
Open

Douglasymlai wants to merge 4 commits into
mainfrom
feat/meeting-notes

Conversation

@Douglasymlai

@Douglasymlai Douglasymlai commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

Related Issue

N/A — maintainer-directed work; no linked issue required for this PR.

Description

Problem

People hold meetings on Zoom, Meet, Teams or in the room, and then retype what was decided before Eigent can help with the follow-up. Eigent could not record a meeting, and there was no place to keep meeting notes that several Spaces can use.

What this adds

A first working version of Meetings, a library next to Spaces (plan: docs/meeting-notes-plan.md, §10 describes this version).

  • Meetings place. A Meetings entry in the Home sidebar, below All Spaces. The library groups meetings by Today, Yesterday, This week and then by month, with search, New meeting and Import recording (m4a, mp3, wav, ogg, webm, mp4).
  • Recording the microphone. Before the first recording, a consent reminder ("Let everyone know you're recording…") with Don't show again. Eigent then asks for the microphone:
    • The main process reads the OS permission (systemPreferences.getMediaAccessStatus) and on macOS asks for it (askForMediaAccess), which shows the system prompt the first time.
    • A denied or restricted permission stops there. The page explains it and offers Open System Settings, which opens the OS microphone privacy pane on macOS and Windows. A missing, busy or unplugged microphone is explained the same way. None of these throws, and no meeting is created when the microphone can't open.
  • Recording is always visible. While recording, a pill with a red dot, the state in words (Recording / Paused / Saving), the elapsed time, Open and Stop stays in the bottom-right corner of every page. The meeting page has Pause, Resume, Stop and a field for typed notes, each kept with its time in the meeting.
  • Keeps going. The recorder lives in a store, not a page, so recording continues while you move to a Space or Settings. Closing the window or quitting during a recording asks first, then saves what was recorded.
  • Meeting page. Title, date, duration and status. Tabs: Note (editable, starts from the plan's one format: Summary, Decisions, Action items, Open questions), Your notes (typed lines with times) and Recording (playback). Delete removes the recording and notes from this computer.
  • Add to Space. Writes Meetings/<YYYY-MM-DD> <title>.md into the Space folder, with front matter, the note and the typed notes, so it shows in Files and Sessions can use it. Eigent stores a digest of each copy:
    • When the note changes, the meeting page shows "Changed since it was added to " with Update copy.
    • If the copy was edited in the Space, or a file Eigent didn't write is at that path, Eigent asks before replacing it.
    • Removing a link or deleting the meeting leaves the Space file.
  • Storage. Only on this computer, under ~/.eigent/meetings/: meetings.sqlite (meetings, notes, Space links) and recordings/<meeting id>/. Nothing is synced. Logs hold meeting ids only, never titles or notes. A meeting left Recording after a crash or reload becomes Interrupted and keeps what was saved.
  • Packaging (macOS). NSMicrophoneUsageDescription in mac.extendInfo and the com.apple.security.device.audio-input entitlement for the hardened runtime.

Backend: new backend/app/meetings/ (store, note rendering, Space copy) and /meetings routes behind the local-control check, like the other local routes.

Plan changes (in this PR, docs/meeting-notes-plan.md §10.2). The plan puts capture in the Swift bridge from the Apple Intelligence models plan (#2157), which isn't on main yet. So this version records the microphone in the renderer (getUserMedia + MediaRecorder). That also makes microphone recording work on Windows and Linux, where the plan offered import only. System audio, live transcription and model-written notes wait for the bridge. The plan doc also records the changed routes (a recording upload/download route; pause/resume stay in the renderer) and the tables left for later.

Not done yet

  • System audio (Core Audio process tap), live transcript (You / Others), final transcription pass, transcript search: need the Apple bridge (§8 PR 1).
  • Notes written by a model (on-device or a picked model, chunking, structured output): need §8 PR 4 / models plan PR 2. Today the person writes the note from the template.
  • Menu bar item, start/stop shortcut, app-menu entry.
  • Settings → Meetings: language, default sources, note model, retention (keep audio / delete when ready / delete after 30 days), storage used, Delete all recordings.
  • Start a session from a meeting and + → Meeting note in the composer.
  • Export Markdown, Show recording in Finder, Include full transcript, the Space filter in the library.
  • Sleep/wake handling (pause on sleep, mark the gap). Recording surviving a window reload (comes with capture in the bridge).
  • Waiting for a Run that is writing in the Space before copying (today the copy takes the existing advisory folder lock only).
  • Spike results for §5.3 (permission owner when the bridge records) and §7 Q4 (echo).

Testing Evidence (REQUIRED)

CI: all 11 checks pass on 980fd883 (Python tests, frontend guardrails, pre-commit, CodeQL, markdown lint, Electron preview and stream-relay tests, web + local Brain smoke).

Automated, also run locally on Windows:

  • Backend: uv run pytest tests/app/meetings tests/app/controller/test_meeting_controller.py — 22 passed (store, recovery of interrupted recordings, search, file names, Space copy never overwriting an edited or foreign file, path containment, routes, local-control auth, import format check, delete keeping Space copies). Pre-commit (ruff, ruff-format, bandit) clean.
  • Renderer: new tests for the microphone permission flow (denied / restricted / no device / unsupported / IPC failure, none throwing), the recording store (start, pause/resume timing, typed notes, stop and upload, save failure, unplugged microphone), the main-process permission handlers (macOS prompt only when undetermined, fixed settings URLs only), library grouping, and the library UI (consent reminder → denied microphone explained, no meeting created).
  • npm run type-check, ESLint on changed files, npm run check:design-tokens, scripts/check-electron-access.sh, i18n locale parity, markdownlint.

Not yet done: manual checks on real machines and screenshots. A tester should go through the checklist below and attach screenshots.

What a tester should check

  • macOS (signed build): first New meeting shows the consent reminder, then the macOS microphone prompt naming Eigent. Allow → recording starts, the pill shows in the corner on every page. Deny → explained, Open System Settings opens Privacy & Security → Microphone, the app doesn't crash. Turn access back on and record again. Record, pause, resume, add typed notes, stop; play back the recording. Quit (⌘Q) while recording → asked first; after confirming, the meeting is saved. Add to two Spaces, check Meetings/…md in Files, edit the note → Update copy; edit the file in the Space → Eigent asks before replacing. Delete the meeting → Space files remain.

  • Windows: with Settings → Privacy → Microphone off for desktop apps, New meeting explains the denial and Open System Settings opens the microphone privacy page. With it on, record, stop, play back. Close the window while recording → asked first.

  • Linux: record with a microphone; unplug it mid-recording → "The microphone was disconnected", what was recorded is saved. With no microphone → "No microphone was found".

  • All: import an m4a/mp3, check the library groups and search, light and dark themes, and that ~/.eigent/meetings/ holds meetings.sqlite and recordings/<id>/.

  • I have included human-verified testing evidence in this PR.

  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).

  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

🤖 Generated with Claude Code

@Douglasymlai Douglasymlai added the 1.0.9 Planned for the 1.0.9 release label Nov 10, 2026
Douglasymlai and others added 3 commits November 18, 2026 23:48
First working version of Meetings (docs/meeting-notes-plan.md §10):

- Meetings library in the Home sidebar: grouped by day, search,
  New meeting and Import recording.
- Microphone recording in the renderer. The main process checks the OS
  permission and asks on macOS first; a denied, missing or busy
  microphone is explained, with Open System Settings, and never throws.
- A recording indicator on every page, pause/resume/stop, typed notes
  with their time, and a close/quit guard that saves the recording.
- Meeting page with an editable note, typed notes and playback.
- Add to Space writes Meetings/<date> <title>.md into the Space folder,
  tracks a digest, offers Update copy, and asks before replacing a file
  that was edited in the Space. Deleting keeps Space copies.
- Backend store at ~/.eigent/meetings (meetings.sqlite + recordings),
  /meetings routes behind local control, recovery of interrupted
  recordings.
- NSMicrophoneUsageDescription and the audio-input entitlement.

The plan doc now records where this version differs: capture runs in the
renderer (microphone only) until the Apple bridge lands, so system audio,
transcription and model-written notes are left for later.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Douglasymlai Douglasymlai changed the title docs: plan meeting recording and notes that can be added to any Space feat: record meetings and add their notes to any Space Nov 19, 2026
@Douglasymlai
Douglasymlai marked this pull request as ready for review November 19, 2026 10:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.0.9 Planned for the 1.0.9 release Review Required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant