Standardization of MPGD description, facilitating the navigation thro…#1077
Merged
Conversation
…ugh TGeometry.
This is in particular taken advantage by the "hit_matching" script.
i) Numbering: starts @ 0 (this concerns layer and module).
ii) The name of layer and module nodes contains the word "Layer"/"Module" .
iii) The name of the Sensitive Volume is "DriftGap" or for the 2DStrip version,
where there are Multiple Sensitive Volumes, "ReferenceThinGap".
Also, the angular aperture of CyMBaL used in segmentation is also corrected.
for more information, see https://pre-commit.ci
Contributor
Author
|
Hello, |
github-actions
Bot
added
topic: tracking
topic: barrel
veprbl
approved these changes
Apr 21, 2026
Member
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
Diff LGTM, confirmed that indices change does not need material map update:
capybara capy pr 1077 --artifact-name material_map --repo epic
diff <(cbor2 2026-04-19T16-54-10+00-00_dccbc23a1657f4c91e3b7103e76529edfa13c1c9/material_map/material-map.cbor) <(cbor2 2026-04-21T08-46-17+00-00_e5b4fa3e97dc1599cdb976bfccc22ca1b452facc/material_map/material-map.cbor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ugh TGeometry.
This is in particular taken advantage by the "hit_matching" script.
i) Numbering: starts @ 0 (this concerns layer and module).
ii) The name of layer and module nodes contains the word "Layer"/"Module" .
iii) The name of the Sensitive Volume is "DriftGap" or for the 2DStrip version,
where there are Multiple Sensitive Volumes, "ReferenceThinGap".
Also, the angular aperture of CyMBaL used in segmentation is also corrected.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
What is the urgency of this PR?
What kind of change does this PR introduce?
eic/snippets(Tracking/TrackHitContributions/hit_matching: 2DStrip-compatibility. snippets#23).