Conversation
Pass the PR target branch name and SHA through the GitLab trigger variables so downstream benchmark pipelines can use them for artifact comparison. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR forwards the PR target branch name and target SHA from GitHub Actions into the GitLab-triggered benchmark pipelines so downstream benchmarks can compare artifacts against the correct base.
Changes:
- Add
GITHUB_BASE_REFandGITHUB_BASE_SHAto the variables passed from GitHub Actions to the GitLab trigger. - Propagate these variables into the
.benchmarksjob template so they’re available to downstream triggered benchmark pipelines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/mirror.yaml |
Adds GITHUB_BASE_REF/GITHUB_BASE_SHA to the GitLab trigger variables computed from the PR payload. |
.gitlab-ci.yml |
Forwards GITHUB_BASE_REF/GITHUB_BASE_SHA through the .benchmarks template variables. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Pass the PR target branch name and SHA through the GitLab trigger variables so downstream benchmark pipelines can use them for artifact comparison.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
AI write this. Well, not this.