First open source pull request! #26
First open source pull request! #26bcarson wants to merge 1 commit intoeggheadio-github:masterfrom bcarson:master
Conversation
|
Fantastic! Thanks for the pull request! Let me add a few inline comments for you. I have some feedback :-) |
src/sort-array.js
Outdated
| export default sortArray | ||
|
|
||
| /** | ||
| * Original Source: http://stackoverflow.com/questions/5476736/javascript-sort-array |
There was a problem hiding this comment.
Could you link this to the specific answer that this is using? There's a share link below the answer.
|
Looking pretty good. When you've completed what I've noted, could you follow the instructions on how to squash your commits? When you do, you'll get a chance to update your commit message which must follow our conventions Let me know if you have any trouble! Enjoy learning :D Thanks! |
|
Aye aye captain :) I have to work today, but I’ll incorporate your comments and resubmit soon. From: "Kent C. Dodds" notifications@github.com Looking pretty good. When you've completed what I've noted, could you follow the instructions on how to squash your commits? When you do, you'll get a chance to update your commit message which must follow our conventions Let me know if you have any trouble! Enjoy learning :D Thanks! — |
|
ping :) |
Adding Feature - Sort Array Method includes two tests
|
I squashed my commits but I have merge conflicts, not sure what I did wrong there. |
|
It's quite possible that your local |
2 participants
I think I've got it this time, please let me know if I need to correct anything.
Thanks again for your help Kent!