Fixed submodules exercise to work with newer git versions#389
Fixed submodules exercise to work with newer git versions#389vivekveerappan wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThe ChangesSubmodule Exercise README Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@submodules/README.md`:
- Around line 22-23: The git command in the submodule addition instruction
contains a syntax error where `git-c` appears instead of `git -c` (note the
space instead of hyphen). Correct this typo by changing `git-c
protocol.file.allow=always` to `git -c protocol.file.allow=always` in the
README.md file so the command will execute properly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 03adc5b3-6afb-4c1c-8639-df1d4d758aec
📒 Files selected for processing (1)
submodules/README.md
Fix Git submodule lesson
Summary
The command
git submodule add ../remote includefails as newer git versions block file protocol by defaultgit -c protocol.file.allow=alwaysis a temporary one-time override for just this command.Summary by CodeRabbit