feat(ampsync): allow configuring grpc decode limit#1797
Merged
shiyasmohd merged 3 commits intoedgeandnode:mainfrom Feb 19, 2026
Merged
feat(ampsync): allow configuring grpc decode limit#1797shiyasmohd merged 3 commits intoedgeandnode:mainfrom
shiyasmohd merged 3 commits intoedgeandnode:mainfrom
Conversation
abarmat
force-pushed
the
fix/ampsync-decoded-msg-length
branch
3 times, most recently
from
cf3152f to
48cc47d
Compare
shiyasmohd
approved these changes
Feb 18, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
LGTM ✅
Could you update the docs too crates/bin/ampsync/README.md ?
Contributor
Author
|
@shiyasmohd done |
Contributor
|
@abarmat Commits are not verified 🙂, Could you commit with verified signatures too? |
abarmat
force-pushed
the
fix/ampsync-decoded-msg-length
branch
from
9addb1e to
e47ecdc
Compare
Contributor
Author
|
@shiyasmohd added signatures |
Contributor
Add a grpc_max_decode_mb option to ampsync config and propagate it through a new AmpClient constructor so the Arrow Flight client can raise its max decoding message size when syncing large tables.
Align ampsync docs with the new Flight decode limit setting so operators can tune large table syncs without relying on source inspection. - Add `--grpc-max-decode-mb` to CLI options with default and range - Document `AMPSYNC_GRPC_MAX_DECODE_MB` in environment variable config - Add a tuning note for large Arrow Flight response frames
abarmat
force-pushed
the
fix/ampsync-decoded-msg-length
branch
from
e47ecdc to
97b3a5a
Compare
Contributor
Author
|
@shiyasmohd I forgot about that one, pushed again |
Contributor
|
Thanks for the PR! @abarmat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a grpc_max_decode_mb option to ampsync config and propagate it through a new AmpClient constructor so the Arrow Flight client can raise its max decoding message size when syncing large tables.
Close: #1796