Conversation
The execute_plan method returns a lazy stream, so logging peak memory immediately after execution captured incorrect values. Wrap the stream in PeakMemoryStream to log when the stream is actually consumed or cancelled. - Add PeakMemoryStream wrapper implementing Stream and RecordBatchStream - Move peak memory debug log from execute_plan to PeakMemoryStream::drop - Import Stream, Pin, Context, Poll, SchemaRef, and RecordBatchStream Signed-off-by: Leonardo Yvens <leoyvens@gmail.com>
leoyvens
force-pushed
the
leo/issue-1789
branch
from
fbda7e1 to
0bcd390
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1789.
The
execute_planmethod returns a lazy stream, so logging peak memory immediately after execution captured always 0. Wrap the stream inPeakMemoryStreamto log when the stream is actually consumed or cancelled.Tested manually.