refactor for TV platforms#911
Open
swifty-tekno wants to merge 3 commits into
Open
Conversation
Added AnimationController for smooth auto-skip progress and updated related logic.
Refactor auto-skip functionality for TV and non-TV platforms. Use Timer for TV to avoid performance issues and maintain smooth animation for other platforms.
Owner
|
Separate the skip-marker button debounce from the existing seek double-tap debounce so unrelated skip flows no longer cancel each other within 200ms. Preserve TV skip-marker behavior with countdown text, while avoiding the old wipe animation path for TV. Replace non-TV auto-skip rebuild logic from per-frame setState() via AnimationController.addListener to AnimatedBuilder, limiting updates to the button subtree only. Reduce redundant PlatformDetector.isTV() checks inside the skip marker build path. Keep the base button text logic as-is; it is correct and does not need functional changes.
Author
|
is this better as i said before i dont really know too much i was just trying to add a nice thing to the skip button and forgot about other platforms |
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i might have missed something but it should run like it did before on tv platforms with the new filling skip button on other platforms
i cant test on TV platform
i did flip the bools during testing to see if it would show old style for tv on desktop version and it showed fine like it did before
tbh i dont know what im doing im hoping i got everything so it respects the 200ms timer for tv