refactor: Improve spacing behavior for nested layouts with conditional visibility#2533
Open
kchobantonov wants to merge 23 commits intoeclipsesource:masterfrom
Open
refactor: Improve spacing behavior for nested layouts with conditional visibility#2533kchobantonov wants to merge 23 commits intoeclipsesource:masterfrom
kchobantonov wants to merge 23 commits intoeclipsesource:masterfrom
Conversation
…p layouts now do not have extra paddings
…add up, also fixed the issue where some of the children can be hidden for which no padding is added
…remove extra padding
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@sdirix @lucas-koehler please review - new demo example employee-registration |
Contributor
Author
|
found an issue with horizontal layout when we do not use padding but gap in order to fix the issue with the elements that are invisible because of the security to not have extra space but this breaks when we want to use number of columns in the UI model like |
…ut can't be easily fixed with gap and allowing the v-col cols property to work
Contributor
Author
|
fixing the horizontal and vertical layout by using no-gutters for vertical and fluid for both horizontal and vertical layouts |
…nvisible elements to not have extra padding from the v-col
…ements that are not visible.
Contributor
Author
|
fix removing extra paddings for invisible elements by not creating the v-col for such elements. |
…not have v-container paddings
Contributor
Author
|
@sdirix @lucas-koehler please review - the pr is ready now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visible: falseMake the group layout and array layouts/control to use collapsable panels to make it easy to deal with array with large number of elements if we want to collapse the whole array UI into just one row.
Make the space usage similar to react - e.g. remove exta margins and/or paddings
Other minor fixes