Removal of double mat-cards for objects#2485
Open
DerMagereStudent wants to merge 1 commit intoeclipsesource:masterfrom
Open
Removal of double mat-cards for objects#2485DerMagereStudent wants to merge 1 commit intoeclipsesource:masterfrom
DerMagereStudent wants to merge 1 commit intoeclipsesource:masterfrom
Conversation
eclipsesource#2480 Dont wrap the object content in a mat-card if a group is used to display it; it has its own mat-card. Still use card when using a plain horizontal layout.
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
sdirix
requested changes
Sep 22, 2025
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
@DerMagereStudent Thanks for the contribution ❤️
Personally I think we should just align with the other renderer sets, see here for example. So let's not render a mat-card at all in the object renderer.
Please also make sure that all test cases succeed
lucas-koehler
force-pushed
the
master
branch
4 times, most recently
from
24c8cb2 to
d86047e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2480 Dont wrap the object content in a mat-card if a group is used to display it; it has its own mat-card. Still use card when using a plain horizontal layout.