Skip to content

fix: blank line for import - #1545

Open
manourym wants to merge 2 commits into
eclipse-tractusx:mainfrom
manourym:manourym/patch-kit-template-logoImport
Open

manourym wants to merge 2 commits into
eclipse-tractusx:mainfrom
manourym:manourym/patch-kit-template-logoImport

Conversation

@manourym

Copy link
Copy Markdown
Contributor

Description

Official README requires blank lines around the import statement, otherwise a compilation error occurs: https://github.com/micromark/micromark-extension-mdxjs-esm#unexpected-type-in-code-only-importexports-are-supported
This patch introduces blank lines around the import statement in the graduated KIT template, so there are no compilation errors when it is used.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Official README requires blank lines around the import statement, otherwise a compilation error occurs: https://github.com/micromark/micromark-extension-mdxjs-esm#unexpected-type-in-code-only-importexports-are-supported
@matbmoser

Copy link
Copy Markdown
Contributor

to add this empty new line is fine.

But why you remove here the success story and not in the KIT PR?

@manourym

manourym commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

to add this empty new line is fine.

But why you remove here the success story and not in the KIT PR?

This was by accident, there have been pushes to the main branch on which did the change - feel free to to close the PR and jsut add the blank line in main without PR.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Pull request preview

The website was built from this pull request and is available here:

🌐 Preview URL: https://eclipse-tractusx.github.io/pr/1545/

This comment is updated automatically on every push. The preview is removed once the pull request is closed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants