Conversation
Split the monolithic .bazelrc into score.bazelrc/ files and rename the platform configs to the score-<os>-<cpu> scheme. The old bl-* names are kept as aliases. Fixes #455
github-actions
Bot
added
comp-flatbuffers
Contributor
|
Documentation preview for this pull request is available at: |
fbaeuerle
force-pushed
the
fb/519/injectable_warnings
branch
from
September 25, 2026 12:18
2367648 to
6bb1468
Compare
github-actions
Bot
added
comp-concurrency
fbaeuerle
force-pushed
the
fb/519/injectable_warnings
branch
from
September 25, 2026 12:57
6bb1468 to
fc3eac0
Compare
The next commit activates strict_warnings, which adds -Wdouble-promotion on Linux and -Wshadow and -Wconversion on QNX: the vajson number cast promotes a float to double in the comparison, two tests shadow an outer local, and procmgr_value_current passes its uint64_t return value to createFromErrno. That value is UINT64_MAX on failure, so take the error from errno instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
score_bazel_cpp_toolchains 1.0.0 removed its built-in features, so bump to 1.0.3 and inject the policy-owned ones via extra_known_features. Without that the feature names silently do nothing. The injected flags come after a target's own copts, so the warning levels are enabled in REPO.bazel, for this repository only. warnings_as_errors stays in .bazelrc, which is read for the root module only and keeps -Werror out of consumers' builds. The policy covers GCC only, so clang-tidy and llvm_cov drop strict_warnings and warnings_as_errors. Dropping the global -strict_warnings negation from .bazelrc activates strict warnings for the first time; it used to override the per-target features attribute. Closes #519 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
treat_warnings_as_errors, additional_warnings and strict_warnings_no_error were never defined by any toolchain and were silently ignored.
fbaeuerle
force-pushed
the
fb/519/injectable_warnings
branch
from
September 25, 2026 18:01
fc3eac0 to
1d65bd4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split .bazelrc into score.bazelrc/ and rename the platform configs to
score--; the bl-* names stay as aliases.
score_bazel_cpp_toolchains 1.0.0 dropped its built-in features, so bump to
1.0.3 and inject the score_cpp_policies ones. Same reason the dead names go
from COMPILER_WARNING_FEATURES. Strict warnings are now actually active,
hence the vajson number cast fix.
Closes #455
Closes #519