Repository navigation
Let snapshot commands take Plugin rows - #218
Merged
Merged
Conversation
zipxSnapshotAdvance, zipxSnapshotStatus, and zipxPinRelease only took Lib rows, so a plugin pinned to another repo's commit (sbt-specular, sbt-splice) had to be edited by hand. A row is now any catalog row. A plugin row is a family of one, its published name is crossed for the sbt running the build, and PinRewrite rewrites the constructor the row is written with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zipxSnapshotAdvance,zipxSnapshotStatus, andzipxPinReleaserefusedPluginrows ("'sbt-specular' is not a row zipxSnapshotAdvance can take"). A plugin pinned to another repo's commit, such as sbt-specular or sbt-splice, had to be edited by hand. Found while moving heddle onto specular's commit.sbt-specular_sbt2_3), through the samePublishedNamesthe catalog update uses.PinRewrite.replacetakes the row and rewrites the constructor it is written with,Lib(...)orPlugin(...).snapshot-planscripted test moves a plugin row onto its line's commit, reads its status, and pins it back to its release.SnapshotPlanSpeccovers the rewrite for both constructors.Proof:
sbt "scalafmtAll; cleanFull; testFull"passes, plusplugin/scriptedforsnapshot-plan,mutual-snapshots, andrelease-workflow.