Repository navigation
Conversation
Let BUILD_ENSURE_FREE_DISK_SPACE env override the flag fallback, so a self-hosted cluster without LaunchDarkly can enable the build-time rootfs grow by adding env BUILD_ENSURE_FREE_DISK_SPACE=true to the orchestrator nomad job. Mirrors the existing envBoolOr pattern (UFFD_INSTALL_DEDUP, CREATE_HUGEPAGE_ADMISSION, etc.). Default unchanged (false).
AdaAibaby
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
October 31, 2026 10:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add an env-var fallback to the
build-ensure-free-disk-spacefeature flag:Why
On a self-hosted cluster without LaunchDarkly, a bool flag resolves to its hardcoded fallback and only a rebuild can change it. This makes the build-time rootfs grow (
ensurefreediskphase) impossible to toggle at deploy time.With this change the operator can enable it by adding an env to the orchestrator nomad job:
Notes
envBoolOrpattern already used byUFFD_INSTALL_DEDUP,PAUSE_REFUSAL_RESTORE,CREATE_MEMORY_REFUSAL,CREATE_HUGEPAGE_ADMISSION,ENVD_BINARY_CACHE.false); LaunchDarkly still overrides when present.gofmt/go vet/build clean./cc @ryan-sana