Repository navigation
chore: bump CI Node to 22.23.4 and tests certifi to 2026.10.19 - #357
Conversation
PR SummaryLow Risk Overview The manual release npm publish step keeps Node 24 for OIDC/npm 11 but replaces floating
Reviewed by Cursor Bugbot for commit 8f99fb8. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. All paths here have a CODEOWNER, and the change swaps lockfile hashes for a security fix, so a human look is still worthwhile.
What was reviewed:
.tool-versionsNode 20 → 22.23.4: lint.yml and the release.yml setup step at line 56 both read it throughenv.TOOL_VERSION_NODE, so the version is still set in one place.- The publish job pins 24.22.1 instead of
24.x. Running ahead of the 22 baseline is intentional, per the existing comment about npm 11 and OIDC. tests/uv.lockchanges only certifi and therevisionheader, and the new version matchescertifi==2026.10.19in both template requirements files. I couldn't check the new sdist and wheel sha256 values against PyPI from here, so someone should confirm them.
Extended reasoning...
The change touches CI tooling only. It bumps Node in .tool-versions, pins the Node version in the npm-publish step, renames one step in lint.yml, and updates the certifi entry in tests/uv.lock. It touches no application code. The supply-chain-sensitive part is the lockfile hash swap for certifi, which this review could not check against PyPI, and the PR's motivation is a CA key-compromise fix. A CODEOWNERS rule (*) covers every changed file, which rules out auto-approval.
Moves CI off EOL Node 20 (which got no patched release) to 22.23.4 in
.tool-versions, pins the npm-publish job's floating24.xto 24.22.1 so a runner's cached older 24.x can't be used, and bumps certifi intests/uv.lockfrom 2026.7.22 to 2026.10.19 — the versions the eMudhra intermediate CA key-compromise disclosure lists as patched. Node 20 was not a compatibility floor here (.tool-versionsnotes it only runs Changesets; the SDKs live in the E2B monorepo), and the template already pinscertifi==2026.10.19. The lock diff is certifi plus uv 0.13.4's lockfilerevisionheader (3 → 5); no other package re-resolved. Reviewers: watch Lint (pnpm install under Node 22); the publish job only runs on a manual release, so 24.22.1 is first exercised then.