Skip to content

fix: resolve candidate provenance in doctor - #147

Merged
e0ipso merged 1 commit into
mainfrom
fix/146-fix-false-dangling-provenance-warnings-i
Oct 21, 2026
Merged

e0ipso merged 1 commit into
mainfrom
fix/146-fix-false-dangling-provenance-warnings-i

Conversation

@e0ipso

@e0ipso e0ipso commented Oct 21, 2026

Copy link
Copy Markdown
Owner

Doctor reports candidate provenance such as <session_id>:practice:0 as dangling even when the session log and proposal exist. Resolve these references against the retained session's frontmatter ID and indexed practice/map proposal, including processed session-log stage-live sessions.

Missing sessions, missing or invalid proposals, malformed identities, and invalid indices still warn. Existing URL, file-path, and retired-node redirect resolution remains intact, and the checker preserves node metadata. Document why gitignored session logs may be absent on another clone and why logs prune does not remove them.

Validation:

  • Regression tests failed before the fix and passed afterward, including the built CLI with a processed stage-live session and source removal.
  • npm test: 953 tests passed across 92 files, including the CLI/template rebuild.
  • npm run typecheck and npm run typecheck:tests: passed.
  • npm run lint: passed with three existing unused eslint-disable warnings in vendored skill scripts.
  • Changed TypeScript formatting and git diff --check: passed.

Fixes #146

Resolve candidate origins against retained session proposals, including
processed stage-live sessions. Keep missing or malformed sources as
warnings and preserve provenance metadata and existing resolution rules.

Cover practice/map origins, invalid sources and indices, source removal,
and unchanged node metadata. Document session-retention diagnostics.
@e0ipso
e0ipso merged commit 66fec53 into main Oct 21, 2026
1 check passed
github-actions Bot pushed a commit that referenced this pull request Oct 21, 2026
## [1.19.3](v1.19.2...v1.19.3) (2026-10-21)

### Bug Fixes

* resolve candidate provenance in doctor ([#147](#147)) ([66fec53](66fec53)), closes [#146](#146)
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix false dangling-provenance warnings in doctor

1 participant