Skip to content

Basic git hooks - #44

Open
ulgens wants to merge 5 commits into
dylanroscover:mainfrom
ulgens:basic-git-hooks
Open

Basic git hooks#44
ulgens wants to merge 5 commits into
dylanroscover:mainfrom
ulgens:basic-git-hooks

Conversation

@ulgens

@ulgens ulgens commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

A soft entry for automated format & lint flows.

Fixes trailing whitespaces and end-of-file issues.

@ulgens
ulgens marked this pull request as ready for review July 9, 2026 12:14
@ulgens
ulgens force-pushed the basic-git-hooks branch from 51c8d42 to cff7f8c Compare July 9, 2026 12:26
@ulgens
ulgens force-pushed the basic-git-hooks branch from cff7f8c to 6ecd3e5 Compare July 9, 2026 15:25
@dylanroscover

Copy link
Copy Markdown
Owner

workflow itself is great and i want to land it — but the fixers need an exclude: for the TD-written trees (dev/embody/, dev/specimen_lab/, specimens/). two examples from this diff:

  • the missing final newlines are just how TD serializes DATs. the fixer adds them, TD strips them on next save, CI goes red forever
  • divergent_defaults.tsv: 276 rows end in a tab because the 4th column is legitimately empty — the hook deleted those cells, TD will put them back

add the exclude + drop the fix commits for those paths and this merges as-is. (wrote CONTRIBUTING.md to document all this — your PRs prompted it tbh)

@ulgens

ulgens commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

the missing final newlines are just how TD serializes DATs. the fixer adds them, TD strips them on next save, CI goes red forever

I'll check why TD is doing that, and if there are any ways to fix that behaviour.

That being said, with a git hook setup, fixer would apply these fixes before the commit is made so ideally (developers should have the hooks initialized on their locals) those un-fixed files wouldn't reach the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants