Fix pointer retrieval in NodeObject::Get for V8 version 14 and above#159
Fix pointer retrieval in NodeObject::Get for V8 version 14 and above#159durs merged 2 commits intodurs:masterfrom
Conversation
|
should fix this issue: |
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s ObjectWrap unwrapping helper to remain compatible with newer V8 (>= 14), addressing an incompatibility encountered with Electron 41.
Changes:
- Use the V8 >= 14
GetAlignedPointerFromInternalFieldoverload that includes an embedder data type tag. - Keep backward compatibility by falling back to the pre-V8-14 API via preprocessor guards.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
It's a bit more complicated V8 < 11.4 Until 2023 V8 11.4 – 13.x 2023–2024 V8 14.1+ 2024+ |
|
hm. I will test with node 25. |
This is also not true, the AI lied |
|
It seems like this only starts with version V8 14.3 |
This fixes an incompatibility with Electron 41