Skip to content

Always set client-tracked click ID if successful #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steven-tey merged 1 commit into from
Jan 12, 2026
Merged

Always set client-tracked click ID if successful #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/script/src/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,6 @@

clientClickTracked = true;

const params = new URLSearchParams(location.search);
const serverClickId = params.get(DUB_ID_VAR);

fetch(`${API_HOST}/track/click`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
Expand All @@ -216,12 +213,6 @@
.then((res) => res.ok && res.json())
.then((data) => {
if (data) {
if (serverClickId && serverClickId !== data.clickId) {
console.warn(
`[dubAnalytics] Client-tracked click ID ${data.clickId} does not match server-tracked click ID ${serverClickId}, skipping...`,
);
return;
}
cookieManager.set(DUB_ID_VAR, data.clickId);
// if partner data is present, set it as dub_partner_data cookie
if (data.partner) {
Expand Down